From: Guenter Roeck <linux@roeck-us.net>
To: Chris Murphy <bugzilla@colorremedies.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Josh Boyer <jwboyer@fedoraproject.org>,
khali@linux-fr.org, lm-sensors@lm-sensors.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: applesmc oops in 3.10/3.11
Date: Wed, 2 Oct 2013 13:59:31 -0700 [thread overview]
Message-ID: <20131002205931.GA18939@roeck-us.net> (raw)
In-Reply-To: <C9769B51-5DE0-4679-8A4E-F4569489F405@colorremedies.com>
On Wed, Oct 02, 2013 at 12:33:00PM -0600, Chris Murphy wrote:
>
> On Oct 2, 2013, at 12:02 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>
> > On Wed, Oct 02, 2013 at 07:24:10PM +0200, Henrik Rydberg wrote:
> >> On Wed, Oct 02, 2013 at 09:47:18AM -0700, Guenter Roeck wrote:
> >>> On Wed, Oct 02, 2013 at 06:34:18PM +0200, Henrik Rydberg wrote:
> >>>>>>> One thing I have seen in all logs is the earlier "send_byte fail" message, so
> >>>>>>> I think that is a pre-requisite.
> >>>>>>
> >>>>>> Not necessarily - it could be that the patch actually fixes the root
> >>>>>> cause. One possible scenario is that on recent SMCs, some of the
> >>>>>> commands produce more data than we actually read. This would
> >>>>>> eventually lead to both data corruption and overflow somwhere in the
> >>>>>> SMC internals. If the original SMC error is interpreted as a read
> >>>>>> buffer overflow, then that problem should be fixed with this patch.
> >>>>>>
> >>>>>
> >>>>> Good point.
> >>>>>
> >>>>> But shouldn't we at least get the "flushed %d bytes" warning message in this case ?
> >>>>
> >>>> The explanation I have there is that the (newer) SMC needs the
> >>>> application to read the 'no more bytes' or it will get confused. It
> >>>> makes sense, if the number of bytes to read is no longer specified.
> >>>>
> >>> You mean that just reading from APPLESMC_CMD_PORT would solve the problem ?
> >>> That might make sense.
> >>
> >> It also points at the possibility of a smaller patch to test, but I
> >> have not had the time to check this very deeply myself:
> >>
> > I like this patch much more than the previous patch. Chris, can you test it ?
>
> Yes. Building now. What kernel message should I be looking for? At least on 2011 and 2012 laptops I have yet to see an Oops related to smc. The kernel with previous patch at least is not causing problems on them so far, which works well as I can test more on the 2008 model.
>
None, if I understand correctly and if the patch really fixes the root cause
of the problem.
Guenter
next prev parent reply other threads:[~2013-10-02 20:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 19:06 applesmc oops in 3.10/3.11 Josh Boyer
2013-09-25 19:56 ` Guenter Roeck
2013-09-25 21:48 ` Henrik Rydberg
2013-09-25 22:08 ` Guenter Roeck
2013-09-26 6:34 ` Henrik Rydberg
2013-09-26 10:36 ` Guenter Roeck
2013-09-26 11:13 ` Henrik Rydberg
2013-09-26 10:53 ` Guenter Roeck
2013-09-26 11:11 ` Henrik Rydberg
2013-09-27 16:21 ` Josh Boyer
2013-09-27 17:12 ` Guenter Roeck
2013-09-27 17:41 ` Chris Murphy
2013-09-27 17:59 ` Guenter Roeck
2013-09-27 18:03 ` Chris Murphy
2013-09-27 23:33 ` Guenter Roeck
2013-10-01 1:57 ` Chris Murphy
2013-10-01 3:37 ` Guenter Roeck
2013-10-01 10:55 ` Henrik Rydberg
2013-10-01 15:19 ` Guenter Roeck
2013-10-01 15:33 ` Chris Murphy
2013-10-01 16:24 ` Guenter Roeck
2013-10-02 1:09 ` Chris Murphy
2013-10-02 3:51 ` Guenter Roeck
2013-10-02 3:55 ` Chris Murphy
2013-10-02 4:02 ` Guenter Roeck
2013-10-02 9:53 ` Henrik Rydberg
2013-10-02 13:30 ` Guenter Roeck
2013-10-02 16:34 ` Henrik Rydberg
2013-10-02 16:47 ` Guenter Roeck
2013-10-02 17:24 ` Henrik Rydberg
2013-10-02 18:02 ` Guenter Roeck
2013-10-02 18:33 ` Chris Murphy
2013-10-02 20:59 ` Guenter Roeck [this message]
2013-10-02 21:34 ` Chris Murphy
2013-10-02 23:32 ` Guenter Roeck
2013-10-07 23:42 ` Guenter Roeck
2013-10-07 23:46 ` Chris Murphy
2013-10-08 15:48 ` Guenter Roeck
2013-10-08 16:29 ` Henrik Rydberg
2013-10-08 16:29 ` Guenter Roeck
2013-10-09 8:29 ` Henrik Rydberg
2013-10-09 16:52 ` Guenter Roeck
2013-09-27 18:01 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002205931.GA18939@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bugzilla@colorremedies.com \
--cc=jwboyer@fedoraproject.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox