From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753556Ab3JBX4X (ORCPT ); Wed, 2 Oct 2013 19:56:23 -0400 Received: from mail.skyhub.de ([78.46.96.112]:51706 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753393Ab3JBX4V (ORCPT ); Wed, 2 Oct 2013 19:56:21 -0400 Date: Thu, 3 Oct 2013 01:56:15 +0200 From: Borislav Petkov To: Jim Davis Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: Re: randconfig build error with next-20131002, in crypto Message-ID: <20131002235615.GA7419@pd.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 02, 2013 at 03:19:51PM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > LD init/built-in.o > crypto/built-in.o: In function `RSA_verify_signature': > rsa.c:(.text+0x2dc5e): undefined reference to `mpi_get_nbits' > rsa.c:(.text+0x2dc68): undefined reference to `mpi_get_nbits' > rsa.c:(.text+0x2dc89): undefined reference to `mpi_free' > rsa.c:(.text+0x2dca4): undefined reference to `mpi_cmp_ui' > rsa.c:(.text+0x2dcb7): undefined reference to `mpi_cmp' > rsa.c:(.text+0x2dcc6): undefined reference to `mpi_alloc' > rsa.c:(.text+0x2dce7): undefined reference to `mpi_powm' > rsa.c:(.text+0x2dcff): undefined reference to `mpi_get_nbits' > rsa.c:(.text+0x2dd1c): undefined reference to `mpi_get_buffer' > rsa.c:(.text+0x2de07): undefined reference to `mpi_free' > make: *** [vmlinux] Error 1 Looks like someone has forgotten this completely unused MPILIB_EXTRA thing in there. Does this totally untested but obvious patch help? --- From: Borislav Petkov Date: Thu, 3 Oct 2013 01:51:15 +0200 Subject: [PATCH] crypto: Correct RSA MPI dependency 9e235dcaf4f6 ("Revert "crypto: GnuPG based MPI lib - additional sources (part 4)") removed the MPI lib extra stuff but left RSA selecting it while it should select CONFIG_MPILIB instead. Fix it. Reported-by: Jim Davis Cc: Herbert Xu Cc: "David S. Miller" Cc: David Howells Signed-off-by: Borislav Petkov --- crypto/asymmetric_keys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig index 6d2c2ea12559..755f6174585a 100644 --- a/crypto/asymmetric_keys/Kconfig +++ b/crypto/asymmetric_keys/Kconfig @@ -21,7 +21,7 @@ config ASYMMETRIC_PUBLIC_KEY_SUBTYPE config PUBLIC_KEY_ALGO_RSA tristate "RSA public-key algorithm" depends on ASYMMETRIC_PUBLIC_KEY_SUBTYPE - select MPILIB_EXTRA + select MPILIB help This option enables support for the RSA algorithm (PKCS#1, RFC3447). -- 1.8.4 -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --