From: Al Viro <viro@ZenIV.linux.org.uk>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [rfc] rework aio migrate pages to use aio fs
Date: Thu, 3 Oct 2013 03:50:07 +0100 [thread overview]
Message-ID: <20131003025007.GC13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20131003022251.GB13318@ZenIV.linux.org.uk>
On Thu, Oct 03, 2013 at 03:22:51AM +0100, Al Viro wrote:
> > + /*
> > + * Link the inode to a directory entry by creating a unique name
> > + * using the inode sequence number.
> > + */
> > + file = ERR_PTR(-ENOMEM);
> > + this.name = name;
> > + this.len = strlen(name);
> > + this.hash = 0;
>
> Umm... ITYM
> struct qstr this = QSTR_INIT("[aio]", 5);
> , if not
> path.dentry = d_alloc_pseudo(aio_mnt->mnt_sb,
> &(struct qstr)QSTR_INIT("[aio]", 5));
> > + if (!path.dentry)
> > + goto err_module;
and you've leaked that inode, BTW.
Another thing: I'd rather pull everything about setting the inode
up (aops, size, etc.) in there.
Anyway, could you take a look at the last couple of commits in
vfs.git#for-bcrl? Commit message on the last one is an atrocity,
of course...
next prev parent reply other threads:[~2013-10-03 2:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 16:59 [GIT PULL] aio changes for 3.12 Benjamin LaHaise
2013-09-13 18:42 ` Al Viro
2013-09-17 14:18 ` [rfc] rework aio migrate pages to use aio fs Benjamin LaHaise
2013-10-03 2:22 ` Al Viro
2013-10-03 2:50 ` Al Viro [this message]
2013-10-09 13:55 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003025007.GC13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox