From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: arizona: Correct handling of device tree gpio defaults
Date: Thu, 3 Oct 2013 12:59:58 +0100 [thread overview]
Message-ID: <20131003115958.GQ9048@lee--X1> (raw)
In-Reply-To: <1380796936-1174-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Thu, 03 Oct 2013, Charles Keepax wrote:
> The intention is that all out of range values should cause the chips
> default settings to be used and a value of zero should be treated
> literally. Currently all out of range values will hit the second if and
> be treated as a literal zero. This patch adds an else to fix this issue.
Code looks good. I'm not sure I understand the commit message within
the current context.
> Reported-by: Heather Lomond <heather.lomond@wolfsonmicro.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 5ac3aa4..e13355b 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -540,7 +540,7 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> for (i = 0; i < ARRAY_SIZE(arizona->pdata.gpio_defaults); i++) {
> if (arizona->pdata.gpio_defaults[i] > 0xffff)
> arizona->pdata.gpio_defaults[i] = 0;
> - if (arizona->pdata.gpio_defaults[i] == 0)
> + else if (arizona->pdata.gpio_defaults[i] == 0)
> arizona->pdata.gpio_defaults[i] = 0x10000;
> }
> } else {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-10-03 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 10:42 [PATCH] mfd: arizona: Correct handling of device tree gpio defaults Charles Keepax
2013-10-03 11:59 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003115958.GQ9048@lee--X1 \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox