From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] perf tool: more user-friendly errors from trace
Date: Thu, 3 Oct 2013 14:27:26 -0300 [thread overview]
Message-ID: <20131003172726.GD2436@ghostprotocols.net> (raw)
In-Reply-To: <524DA6F9.9000608@gmail.com>
Em Thu, Oct 03, 2013 at 11:18:49AM -0600, David Ahern escreveu:
> On 10/3/13 10:58 AM, Arnaldo Carvalho de Melo wrote:
> >What about the one attached instead? It
> Isnt' strerror(errno) preferred over sys_errlist[errno]?
I found it much simpler to index the array, but can change to using
strerror_r (which I think is preferred over strerror, but one needs to
be careful as there are some subtleties there as well...).
Apart from that, do you think using errno for such simple functions is
ok? i.e. just use the mechanism in place, errno is _already_ set up and
reflects exactly what we need to get propagated to those functions
callers.
- ARnaldo
next prev parent reply other threads:[~2013-10-03 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 8:28 [PATCH] perf tool: more user-friendly errors from trace Ramkumar Ramachandra
2013-10-03 16:58 ` Arnaldo Carvalho de Melo
2013-10-03 17:18 ` David Ahern
2013-10-03 17:27 ` Arnaldo Carvalho de Melo [this message]
2013-10-04 4:52 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003172726.GD2436@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=artagnon@gmail.com \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).