From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] hotplug: Optimize cpu_hotplug_{begin,done}() using rcu_sync
Date: Thu, 3 Oct 2013 11:46:07 -0700 [thread overview]
Message-ID: <20131003184607.GQ5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131003184151.GN28601@twins.programming.kicks-ass.net>
On Thu, Oct 03, 2013 at 08:41:51PM +0200, Peter Zijlstra wrote:
> On Thu, Oct 03, 2013 at 09:48:38AM -0700, Paul E. McKenney wrote:
> > > -enum { readers_fast = 0, readers_slow, readers_block };
> > > +enum { readers_slow, readers_block };
> >
> > It took me a bit to realize that readers_fast is obsoleted by the
> > rcu_sync_is_idle() above. ;-)
>
> Yeah.. I pondered changing/adding to the rcu_sync interface to allow
> using gp_count like status to avoid the extra variable, but decided
> against it for now.
Should be OK as is -- people who haven't reviewed the old version with
readers_fast are unlikely to be confused by the current setup.
Thanx, Paul
next prev parent reply other threads:[~2013-10-03 18:46 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 14:56 [PATCH 0/3] Optimize the cpu hotplug locking Peter Zijlstra
2013-10-02 14:56 ` [PATCH 1/3] hotplug: Optimize {get,put}_online_cpus() Peter Zijlstra
2013-10-03 14:01 ` Peter Zijlstra
2013-10-03 16:27 ` Paul E. McKenney
2013-10-03 16:26 ` Paul E. McKenney
2013-10-02 14:56 ` [PATCH 2/3] rcu: Create rcu_sync infrastructure Peter Zijlstra
2013-10-02 15:49 ` Oleg Nesterov
2013-10-03 16:42 ` Paul E. McKenney
2013-10-08 8:18 ` Peter Zijlstra
2013-10-03 16:41 ` Paul E. McKenney
2013-10-03 17:00 ` Oleg Nesterov
2013-10-03 17:15 ` Paul E. McKenney
2013-10-03 18:40 ` Peter Zijlstra
2013-10-03 18:45 ` Paul E. McKenney
2013-10-03 18:47 ` Oleg Nesterov
2013-10-03 19:21 ` Paul E. McKenney
2013-10-03 19:32 ` Oleg Nesterov
2013-10-03 19:33 ` Oleg Nesterov
2013-10-03 19:50 ` Paul E. McKenney
2013-10-03 20:00 ` Oleg Nesterov
2013-10-03 21:10 ` Oleg Nesterov
2013-10-03 22:00 ` Paul E. McKenney
2013-10-04 11:29 ` Oleg Nesterov
2013-10-04 16:22 ` Paul E. McKenney
2013-10-04 7:18 ` Peter Zijlstra
2013-10-04 11:15 ` Oleg Nesterov
2013-10-04 11:36 ` Peter Zijlstra
2013-10-04 11:50 ` Oleg Nesterov
2013-10-04 11:44 ` Peter Zijlstra
2013-10-04 12:13 ` Oleg Nesterov
2013-10-04 12:38 ` Peter Zijlstra
2013-10-04 13:31 ` Oleg Nesterov
2013-10-04 14:43 ` Peter Zijlstra
2013-10-04 15:13 ` Oleg Nesterov
2013-10-04 16:25 ` Peter Zijlstra
2013-10-04 19:06 ` Oleg Nesterov
2013-10-04 19:41 ` Peter Zijlstra
2013-10-05 17:31 ` Oleg Nesterov
2013-10-04 7:00 ` Peter Zijlstra
2013-10-03 20:14 ` Paolo Bonzini
2013-10-04 7:01 ` Peter Zijlstra
2013-10-02 14:56 ` [PATCH 3/3] hotplug: Optimize cpu_hotplug_{begin,done}() using rcu_sync Peter Zijlstra
2013-10-03 16:48 ` Paul E. McKenney
2013-10-03 18:41 ` Peter Zijlstra
2013-10-03 18:46 ` Paul E. McKenney [this message]
2013-10-03 19:05 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003184607.GQ5790@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).