From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386Ab3JCTug (ORCPT ); Thu, 3 Oct 2013 15:50:36 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:49010 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754810Ab3JCTue (ORCPT ); Thu, 3 Oct 2013 15:50:34 -0400 Date: Thu, 3 Oct 2013 12:50:26 -0700 From: "Paul E. McKenney" To: Oleg Nesterov Cc: Peter Zijlstra , Mel Gorman , Rik van Riel , Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Thomas Gleixner , Steven Rostedt , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] rcu: Create rcu_sync infrastructure Message-ID: <20131003195026.GT5790@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20131002145655.361606532@infradead.org> <20131002150518.675931976@infradead.org> <20131003164117.GD5790@linux.vnet.ibm.com> <20131003184001.GM28601@twins.programming.kicks-ass.net> <20131003184719.GA11996@redhat.com> <20131003192135.GR5790@linux.vnet.ibm.com> <20131003193206.GA17796@redhat.com> <20131003193319.GB17796@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131003193319.GB17796@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13100319-1344-0000-0000-000002235141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 03, 2013 at 09:33:19PM +0200, Oleg Nesterov wrote: > On 10/03, Oleg Nesterov wrote: > > > > Because I believe this needs another patch ;) see below, didn't test > > it yet. > > ... > > struct rcu_sync_ops { > > void (*sync)(void); > > void (*call)(struct rcu_head *, void (*)(struct rcu_head *)); > > +#ifdef CONFIG_PROVE_RCU > > + bool (*held)(void); > ^^^^ > OK, it has to return "int". I missed this, but the rest looked good. ;-) Thanx, Paul