From: Ingo Molnar <mingo@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, eranian@google.com
Subject: Re: [PATCH 11/11] perf: Avoid uninitialized sample type reference in __perf_event__output_id_sample
Date: Fri, 4 Oct 2013 08:24:27 +0200 [thread overview]
Message-ID: <20131004062427.GD11399@gmail.com> (raw)
In-Reply-To: <20131003181652.GH2125@tassilo.jf.intel.com>
* Andi Kleen <ak@linux.intel.com> wrote:
> > Forcing multiple, unnecessary rounds of emails instead of clearly
> > volunteering all technical information that is related to the matter
> > is something Andi is still doing routinely.
>
> Sorry all the information was in the full email thread (including the
> intro). And the patch description clearly described the problem in your
> code.
>
> As the patches spanned many subsystems you were only copied on the
> patches that affect your subsystem, and not on the intro (as git
> send-email doesn't seem to support that)
>
> Here are possible alternatives. Please let me know which ones you prefer
> and I'll try to adapt to your specific preferences in the future:
>
> [ ] Always copy you guys on all patches of
> subsystem spanning patch kits that are mostly of no relevance
> to you.
>
> [ ] Repeat the complete intro in every patch.
>
> [ ] You think uninitialized are not a problem and you
> don't want to see any patches related to that.
>
> [ ] You are not interested in fixing static checker problems in your
> subsystem and don't want to see any patches related to that.
[x] Fix your changelog. Any commit log that is not self-describing to a
maintainer like PeterZ is faulty by definition - regardless of any intro
somewhere else. Changelogs ultimately detach from intros, they will be
read by others in the kernel repo, reviewing changes, looking for bugs,
following development, etc., and if the relevant context is lost then
that changelog is _BROKEN_. This is kernel development 101.
[x] You should stop making idiotic excuses for broken changelogs. The
fact that we had to complain about the quality of your patches and
changelogs for years should give you a big, huge hint that the problem
is still on your side. Writing snarky responses to maintainer questions
does not improve your changelogs, it only wastes PeterZ's, my and other
people's time.
Thanks,
Ingo
prev parent reply other threads:[~2013-10-04 6:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 20:29 Various static checker fixes Andi Kleen
2013-09-30 20:29 ` [PATCH 01/11] random: don't feed stack data into pool when interrupt regs NULL Andi Kleen
2013-09-30 20:51 ` Luck, Tony
2013-10-01 12:44 ` Theodore Ts'o
2014-04-04 16:54 ` Sebastian Andrzej Siewior
2014-04-07 4:01 ` Theodore Ts'o
2014-04-07 19:30 ` Sebastian Andrzej Siewior
2014-04-07 23:26 ` Theodore Ts'o
2014-04-09 18:14 ` rkuo
2013-09-30 20:29 ` [PATCH 02/11] Disable initialized_var for clang Andi Kleen
2013-09-30 20:29 ` [PATCH 03/11] posix-timers: Initialize timer value to 0 for invalid timers Andi Kleen
2013-09-30 20:29 ` [PATCH 04/11] block: Return error code of elevator init function Andi Kleen
2013-10-01 12:25 ` Jeff Moyer
2013-09-30 20:29 ` [PATCH 05/11] seq_file: Handle ->next error in seq_read Andi Kleen
2013-09-30 20:29 ` [PATCH 06/11] sysctl: remove unnecessary variable initialization Andi Kleen
2013-09-30 20:29 ` [PATCH 07/11] igb: Avoid uninitialized advertised variable in eee_set_cur Andi Kleen
2013-10-01 15:00 ` Wyborny, Carolyn
2013-10-01 23:10 ` Jeff Kirsher
2013-10-02 20:33 ` David Miller
2013-09-30 20:29 ` [PATCH 08/11] ext4: Fix end of group handling in ext4_mb_init_cache Andi Kleen
2013-10-01 12:45 ` Theodore Ts'o
2013-10-01 14:20 ` Andi Kleen
2013-09-30 20:29 ` [PATCH 09/11] epoll: Remove unnecessary error path Andi Kleen
2013-09-30 20:59 ` Eric Wong
2013-09-30 21:01 ` Andi Kleen
2013-09-30 20:29 ` [PATCH 10/11] tcp: Always set options to 0 before calling tcp_established_options Andi Kleen
2013-10-02 20:33 ` David Miller
2013-09-30 20:29 ` [PATCH 11/11] perf: Avoid uninitialized sample type reference in __perf_event__output_id_sample Andi Kleen
2013-10-02 8:57 ` Peter Zijlstra
2013-10-02 17:25 ` Andi Kleen
2013-10-02 17:36 ` Peter Zijlstra
2013-10-03 6:42 ` Ingo Molnar
2013-10-03 18:16 ` Andi Kleen
2013-10-04 6:24 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004062427.GD11399@gmail.com \
--to=mingo@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).