From: Janani Venkataraman <jananive@in.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: amwang@redhat.com, rdunlap@xenotime.net, andi@firstfloor.org,
aravinda@linux.vnet.ibm.com, hch@lst.de, mhiramat@redhat.com,
jeremy.fitzhardinge@citrix.com, xemul@parallels.com,
suzuki@linux.vnet.ibm.com, kosaki.motohiro@jp.fujitsu.com,
adobriyan@gmail.com, tarundsk@linux.vnet.ibm.com,
vapier@gentoo.org, roland@hack.frob.com, tj@kernel.org,
ananth@linux.vnet.ibm.com, gorcunov@openvz.org,
avagin@openvz.org, oleg@redhat.com, eparis@redhat.com,
d.hatayama@jp.fujitsu.com, james.hogan@imgtec.com,
akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: [PATCH 10/19] Track the core generation requests
Date: Fri, 04 Oct 2013 16:01:52 +0530 [thread overview]
Message-ID: <20131004103152.1612.64284.stgit@f19-x64> (raw)
In-Reply-To: <20131004102532.1612.24185.stgit@f19-x64>
From:Suzuki K.Poulose <suzuki@in.ibm.com>
Keep track of the core generation requests. Concurrent core generation requests
for the same target process are not allowed.
Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com>
Signed-off-by: Ananth N.Mavinakayanahalli <ananth@in.ibm.com>
---
fs/proc/gencore.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
fs/proc/gencore.h | 12 +++++++
2 files changed, 96 insertions(+), 2 deletions(-)
create mode 100644 fs/proc/gencore.h
diff --git a/fs/proc/gencore.c b/fs/proc/gencore.c
index 115f1e4..580a8b5 100644
--- a/fs/proc/gencore.c
+++ b/fs/proc/gencore.c
@@ -23,23 +23,105 @@
*/
#include <linux/seq_file.h>
+#include <linux/slab.h>
#include "internal.h"
+#include "gencore.h"
+
+static LIST_HEAD(core_list);
+static DEFINE_MUTEX(core_mutex);
+
+/* Called with core_mutex held */
+static struct core_proc* get_core_proc(struct task_struct *t)
+{
+ struct core_proc *cp;
+
+ list_for_each_entry(cp, &core_list, list) {
+ if (cp->task == t->group_leader)
+ return cp;
+ }
+ return NULL;
+}
static ssize_t read_gencore(struct file *file, char __user *buffer,
size_t buflen, loff_t *fpos)
{
- return 0;
+ struct task_struct *task = get_proc_task(file->f_dentry->d_inode);
+ struct core_proc *cp;
+ ssize_t ret = 0;
+
+ if (!task)
+ return -EIO;
+
+ mutex_lock(&core_mutex);
+ cp = get_core_proc(task);
+ if (!cp) {
+ mutex_unlock(&core_mutex);
+ ret = -EIO;
+ goto out;
+ }
+ mutex_unlock(&core_mutex);
+
+out:
+ put_task_struct(task);
+ return ret;
}
static int release_gencore(struct inode *inode, struct file *file)
{
+ struct task_struct *task = get_proc_task(file->f_dentry->d_inode);
+ struct core_proc *cp;
+
+ if (!task)
+ return -EIO;
+
+ mutex_lock(&core_mutex);
+ cp = get_core_proc(task);
+ if (cp) {
+ list_del(&cp->list);
+ kfree(cp);
+ }
+ mutex_unlock(&core_mutex);
+ put_task_struct(task);
return 0;
}
+/*
+ * Validate if the call is valid. We also need to prevent >1 open
+ * of the same file.
+ */
static int open_gencore(struct inode *inode, struct file *filp)
{
- return 0;
+ struct task_struct *task = get_proc_task(inode);
+ struct core_proc *cp;
+ int ret = 0;
+ if (!task)
+ return -ENOENT;
+
+ mutex_lock(&core_mutex);
+ cp = get_core_proc(task);
+ mutex_unlock(&core_mutex);
+ if (cp) {
+ ret = -EALREADY;
+ goto out;
+ }
+
+ cp = kzalloc(sizeof (*cp), GFP_KERNEL);
+ if (!cp) {
+ ret = -ENOMEM;
+ goto out;
+ }
+
+ cp->task = task->group_leader;
+ INIT_LIST_HEAD(&cp->list);
+ mutex_lock(&core_mutex);
+ list_add(&cp->list, &core_list);
+ mutex_unlock(&core_mutex);
+
+out:
+ put_task_struct(task);
+ return ret;
}
+
const struct file_operations proc_gen_core_operations = {
.open = open_gencore,
.read = read_gencore,
diff --git a/fs/proc/gencore.h b/fs/proc/gencore.h
new file mode 100644
index 0000000..c98fddf
--- /dev/null
+++ b/fs/proc/gencore.h
@@ -0,0 +1,12 @@
+#ifndef __GEN_CORE_H
+#define __GEN_CORE_H
+
+#include <linux/list.h>
+#include <linux/sched.h>
+
+struct core_proc {
+ struct list_head list;
+ struct task_struct *task;
+};
+
+#endif
next prev parent reply other threads:[~2013-10-04 10:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 10:30 [RFC] [PATCH 00/19] Non disruptive application core dump infrastructure using task_work_add() Janani Venkataraman
2013-10-04 10:30 ` [PATCH 01/19] Create elfcore-common.c for ELF class independent core generation helpers Janani Venkataraman
2013-10-04 10:30 ` [PATCH 02/19] Make vma_dump_size() generic Janani Venkataraman
2013-10-08 0:23 ` Ryan Mallon
2013-10-08 3:52 ` Janani Venkataraman1
2013-10-04 10:31 ` [PATCH 03/19] Make fill_psinfo generic Janani Venkataraman
2013-10-04 10:31 ` [PATCH 04/19] Rename compat versions of the reusable core generation routines Janani Venkataraman
2013-10-04 10:31 ` [PATCH 05/19] Export the reusable ELF " Janani Venkataraman
2013-10-04 10:31 ` [PATCH 06/19] Define API for reading arch specif Program Headers for Core Janani Venkataraman
2013-10-04 10:31 ` [PATCH 07/19] ia64 impelementation for elf_core_copy_extra_phdrs() Janani Venkataraman
2013-10-04 10:31 ` [PATCH 08/19] elf_core_copy_extra_phdrs() for UML Janani Venkataraman
2013-10-04 10:31 ` [PATCH 09/19] Create /proc/pid/core entry Janani Venkataraman
2013-10-04 10:31 ` Janani Venkataraman [this message]
2013-10-04 10:31 ` [PATCH 11/19] Check if the process is an ELF executable Janani Venkataraman
2013-10-04 10:32 ` [PATCH 12/19] Hold the threads using task_work_add Janani Venkataraman
2013-10-04 10:32 ` [PATCH 13/19] Create ELF Header Janani Venkataraman
2013-10-04 10:32 ` [PATCH 14/19] Create ELF Core notes Data Janani Venkataraman
2013-10-04 10:32 ` [PATCH 15/19] Calculate the size of the core file Janani Venkataraman
2013-10-04 10:32 ` [PATCH 16/19] Generate the data sections for ELF Core Janani Venkataraman
2013-10-04 10:32 ` [PATCH 17/19] Identify the ELF class of the process Janani Venkataraman
2013-10-04 10:33 ` [PATCH 18/19] Adding support for compat ELF class data structures Janani Venkataraman
2013-10-04 10:33 ` [PATCH 19/19] Compat ELF class core generation support Janani Venkataraman
2013-10-04 10:38 ` [RFC] [PATCH 00/19] Non disruptive application core dump infrastructure using task_work_add() Pavel Emelyanov
2013-10-07 18:57 ` Tejun Heo
2013-10-08 10:14 ` Janani Venkataraman1
2013-10-08 10:12 ` Janani Venkataraman1
2013-10-09 8:57 ` Pavel Emelyanov
2013-10-04 13:44 ` Andi Kleen
2013-10-07 6:07 ` Suzuki K. Poulose
2013-10-07 13:58 ` Oleg Nesterov
2013-10-07 18:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004103152.1612.64284.stgit@f19-x64 \
--to=jananive@in.ibm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=andi@firstfloor.org \
--cc=aravinda@linux.vnet.ibm.com \
--cc=avagin@openvz.org \
--cc=d.hatayama@jp.fujitsu.com \
--cc=eparis@redhat.com \
--cc=gorcunov@openvz.org \
--cc=hch@lst.de \
--cc=james.hogan@imgtec.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=oleg@redhat.com \
--cc=rdunlap@xenotime.net \
--cc=roland@hack.frob.com \
--cc=suzuki@linux.vnet.ibm.com \
--cc=tarundsk@linux.vnet.ibm.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vapier@gentoo.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).