* [PATCH] usb: g_ffs: fix compilation warning
@ 2013-10-04 21:48 David Cohen
2013-10-04 21:51 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: David Cohen @ 2013-10-04 21:48 UTC (permalink / raw)
To: gregkh, balbi; +Cc: linux-usb, linux-kernel, David Cohen
Due to lack of "u_ether.h" header file, g_ffs.c compiles with following
warning:
drivers/usb/gadget/g_ffs.c:81:1: warning: data definition has no type or
storage class [enabled by default]
drivers/usb/gadget/g_ffs.c:81:1: warning: type defaults to ‘int’ in
declaration of ‘USB_ETHERNET_MODULE_PARAMETERS’ [-Wimplicit-int]
drivers/usb/gadget/g_ffs.c:81:1: warning: function declaration isn’t a
prototype [-Wstrict-prototypes]
This patch adds the missing header.
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
---
drivers/usb/gadget/g_ffs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/gadget/g_ffs.c b/drivers/usb/gadget/g_ffs.c
index 5327c82..ed3d9ab 100644
--- a/drivers/usb/gadget/g_ffs.c
+++ b/drivers/usb/gadget/g_ffs.c
@@ -13,6 +13,9 @@
#define pr_fmt(fmt) "g_ffs: " fmt
#include <linux/module.h>
+
+#include "u_ether.h"
+
/*
* kbuild is not very cooperative with respect to linking separately
* compiled library objects into one module. So for now we won't use
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: g_ffs: fix compilation warning
2013-10-04 21:48 [PATCH] usb: g_ffs: fix compilation warning David Cohen
@ 2013-10-04 21:51 ` Greg KH
2013-10-04 22:03 ` David Cohen
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2013-10-04 21:51 UTC (permalink / raw)
To: David Cohen; +Cc: balbi, linux-usb, linux-kernel
On Fri, Oct 04, 2013 at 02:48:46PM -0700, David Cohen wrote:
> Due to lack of "u_ether.h" header file, g_ffs.c compiles with following
> warning:
It does? In what tree/branch/release is this happening?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: g_ffs: fix compilation warning
2013-10-04 21:51 ` Greg KH
@ 2013-10-04 22:03 ` David Cohen
2013-10-04 22:08 ` David Cohen
0 siblings, 1 reply; 4+ messages in thread
From: David Cohen @ 2013-10-04 22:03 UTC (permalink / raw)
To: Greg KH; +Cc: balbi, linux-usb, linux-kernel
On 10/04/2013 02:51 PM, Greg KH wrote:
> On Fri, Oct 04, 2013 at 02:48:46PM -0700, David Cohen wrote:
>> Due to lack of "u_ether.h" header file, g_ffs.c compiles with following
>> warning:
>
> It does? In what tree/branch/release is this happening?
This is intended for Linus' 3.12-rc3. Haven't checked any other kernel.
In my compilation I disabled USB Host support and enabled DWC3 (gadget
only) with ePCI + NOP_USB_XCEIV.
Br, David
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: g_ffs: fix compilation warning
2013-10-04 22:03 ` David Cohen
@ 2013-10-04 22:08 ` David Cohen
0 siblings, 0 replies; 4+ messages in thread
From: David Cohen @ 2013-10-04 22:08 UTC (permalink / raw)
To: Greg KH; +Cc: balbi, linux-usb, linux-kernel
On 10/04/2013 03:03 PM, David Cohen wrote:
> On 10/04/2013 02:51 PM, Greg KH wrote:
>> On Fri, Oct 04, 2013 at 02:48:46PM -0700, David Cohen wrote:
>>> Due to lack of "u_ether.h" header file, g_ffs.c compiles with following
>>> warning:
>>
>> It does? In what tree/branch/release is this happening?
>
> This is intended for Linus' 3.12-rc3. Haven't checked any other kernel.
>
> In my compilation I disabled USB Host support and enabled DWC3 (gadget
> only) with ePCI + NOP_USB_XCEIV.
After checking again this patch is not fixing properly.
u_ether.h is conditionally included.
I'll solve it in another way. Please do not consider this patch anymore.
BR, David
>
> Br, David
>
>>
>> thanks,
>>
>> greg k-h
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-04 22:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-04 21:48 [PATCH] usb: g_ffs: fix compilation warning David Cohen
2013-10-04 21:51 ` Greg KH
2013-10-04 22:03 ` David Cohen
2013-10-04 22:08 ` David Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox