From: Steven Rostedt <rostedt@goodmis.org>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jason Baron <jbaron@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Eric Dumazet <edumazet@google.com>,
"andi @ firstfloor. org David S. Miller" <davem@davemloft.net>,
x86@kernel.org
Subject: Re: [PATCH] static_key: WARN on usage before jump_label_init was called
Date: Mon, 7 Oct 2013 11:51:52 -0400 [thread overview]
Message-ID: <20131007115152.0964afde@gandalf.local.home> (raw)
In-Reply-To: <20131006182919.GD9295@order.stressinduktion.org>
On Sun, 6 Oct 2013 20:29:19 +0200
Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:
> diff --git a/lib/jump_label_initialized.c b/lib/jump_label_initialized.c
> new file mode 100644
> index 0000000..a668a40
> --- /dev/null
> +++ b/lib/jump_label_initialized.c
> @@ -0,0 +1,6 @@
> +#include <linux/types.h>
> +#include <linux/cache.h>
> +
> +bool static_key_initialized __read_mostly = false;
> +EXPORT_SYMBOL_GPL(static_key_initialized);
> +
So far, the only thing I don't like about this patch is the creation of
this file for the sole purpose of adding this variable.
Perhaps it can just be added to init/main.c?
-- Steve
next prev parent reply other threads:[~2013-10-07 15:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 23:20 Introduce support to lazy initialize mostly static keys v2 Hannes Frederic Sowa
2013-10-05 23:20 ` [PATCH net-next v2 1/8] ipv4: split inet_ehashfn to hash functions per compilation unit Hannes Frederic Sowa
2013-10-05 23:20 ` [PATCH net-next v2 2/8] ipv6: split inet6_ehashfn " Hannes Frederic Sowa
2013-10-05 23:20 ` [PATCH net-next v2 3/8] x86/jump_label: expect default_nop if static_key gets enabled on boot-up Hannes Frederic Sowa
2013-10-06 0:05 ` Steven Rostedt
2013-10-06 0:12 ` Hannes Frederic Sowa
2013-10-06 18:29 ` [PATCH] static_key: WARN on usage before jump_label_init was called Hannes Frederic Sowa
2013-10-07 15:51 ` Steven Rostedt [this message]
2013-10-07 16:57 ` [PATCH v2] " Hannes Frederic Sowa
2013-10-05 23:20 ` [PATCH net-next v2 4/8] net: introduce new macro net_get_random_once Hannes Frederic Sowa
2013-10-05 23:20 ` [PATCH net-next v2 5/8] inet: split syncookie keys for ipv4 and ipv6 and initialize with net_get_random_once Hannes Frederic Sowa
2013-10-05 23:20 ` [PATCH net-next v2 6/8] inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once Hannes Frederic Sowa
2013-10-05 23:20 ` [PATCH net-next v2 7/8] tcp: switch tcp_fastopen key generation " Hannes Frederic Sowa
2013-10-05 23:20 ` [PATCH net-next v2 8/8] net: switch net_secret " Hannes Frederic Sowa
2013-10-06 2:55 ` Introduce support to lazy initialize mostly static keys v2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131007115152.0964afde@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox