From: Ingo Molnar <mingo@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Tejun Heo <tj@kernel.org>,
akpm@linuxfoundation.org, Steven Rostedt <srostedt@redhat.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [raw v1 0/4] Replace __this_cpu ops with raw_cpu_ops where necessary
Date: Tue, 8 Oct 2013 09:27:43 +0200 [thread overview]
Message-ID: <20131008072743.GB4455@gmail.com> (raw)
In-Reply-To: <0000014194309038-3923fc42-2039-45da-b8fa-2df545112405-000000@email.amazonses.com>
* Christoph Lameter <cl@linux.com> wrote:
> The kernel can detect __this_cpu ops in preemptible contexts after
> the preemption check patchset that I posted last week.
>
> Here is a selection of patches to fix false positives caused by
> the additional checks. So far I have found no bug. Amazing.
> Looks like there was some prior work done to shake these things out?
>
> I ran an upstream kernel using Ubuntu 13.04 + the preempt checking +
> the patches below on my desktop and with the following patches no
> __this_cpu ops triggered messages. The kernel had the default Ubuntu
> desktop configuration (+ CONFIG_PREEMPT + CONFIG_DEBUG_THIS_CPU_OPERATIONS).
Here are the current list of technical problems that still plague your
submission:
- see the technical questions I raised about the snmp patch
- broken threading resulting in patches arriving out of order. (You
ignored peterz's helpful suggestion to upgrade Quilt which would allow
you to fix this.)
- broken subject lines - no 'PATCH' for patches
- inconsistent patch titles: broken, inconsistent subsystem tags, etc.
- incomplete changelogs: you fail to quote the false positive that led
you to a change. In cases this results in a totally context-free
changelog which loses information the moment it's committed upstream.
In particular the last 4 items were mentioned to you for your last
submission - which you failed to fix. You should wait with your next
submission until you have enough time to fix *all* problems that were
reported to you, not just some.
All in one, still a sloppy, incomplete submission.
Thanks,
Ingo
next prev parent reply other threads:[~2013-10-08 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 18:31 [raw v1 0/4] Replace __this_cpu ops with raw_cpu_ops where necessary Christoph Lameter
2013-10-08 7:27 ` Ingo Molnar [this message]
2013-10-08 10:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008072743.GB4455@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linuxfoundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).