From: Gleb Natapov <gleb@redhat.com>
To: chai wen <chaiw.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, pbonzini@redhat.com,
tangchen@cn.fujitsu.com, Gu Zheng <guz.fnst@cn.fujitsu.com>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [RFC/query] kvm async_pf anon pined pages migration
Date: Tue, 8 Oct 2013 10:39:14 +0300 [thread overview]
Message-ID: <20131008073914.GA3574@redhat.com> (raw)
In-Reply-To: <5253AD0E.6060209@cn.fujitsu.com>
On Tue, Oct 08, 2013 at 02:58:22PM +0800, chai wen wrote:
> On 10/02/2013 12:04 AM, chaiwen wrote:
> >On 09/30/2013 08:51 PM, Gleb Natapov wrote:
> >>On Mon, Sep 30, 2013 at 06:03:07PM +0800, chai wen wrote:
> >>>Hi all
> >>>
> >>>Async page fault in kvm currently pin user pages via get_user_pages.
> >>>when doing page migration,the method can be found via
> >>>page->mmapping->a_ops->migratepage to offline old pages and migrate to
> >>>new pages. As to anonymous page there is no file mapping but a anon_vma.So
> >>>the migration will fall back to some *default* migration method.Anon pages
> >>>that have been pined in memory by some reasons could be failed in the migration
> >>>processing because of some reasons like ref-count checking.
> >>>(or I misunderstand some thing?)
> >>>
> >>>Now we want to make these anon pages in async_pf can be migrated, I try some
> >>>ways.But there are still many problems. The following is one that replaceing
> >>>the mapping of anon page arbitrarily and doing some thing based on it.
> >>>Kvm-based virtual machine can works on this patch,but have no experience of
> >>>offline pages because of the limitaion of resouces.I'll check it later.
> >>>
> >>>I don't know weather it is a right direction of this issue.
> >>>All comments/criticize are welcomed.
> >>The pinning is not mandatory and can (and probably should) be dropped, but
> >>pinning that is done by async page faults is short lived. What problems
> >>are you seeing that warrant the complexity of handling their migration?
> Hi Gleb
>
> As to this issue, I still have some thing not very clear.
> If pages pinning is successfully holding (although not mandatory) by
> async page fault.
> And at the same time page migration happens because of memory
> hot-remove action.
> It has 120*hz timeout setting in common page offline processing,
> could it fail with
> these async_pf pined pages migration ?
> What's your opinion about this ? If it may fail under this
> circumstance, should we do
> some thing on it ?
>
120 seconds is more than enough time for pinning to go away, but as I
said the pinning is not even necessary. Patch to remove it is welcomed.
--
Gleb.
next prev parent reply other threads:[~2013-10-09 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 10:03 [RFC/query] kvm async_pf anon pined pages migration chai wen
2013-09-30 12:51 ` Gleb Natapov
[not found] ` <BLU0-SMTP3062A22F7A685B9214BB05AE0150@phx.gbl>
[not found] ` <5253AD0E.6060209@cn.fujitsu.com>
2013-10-08 7:39 ` Gleb Natapov [this message]
2013-10-10 7:05 ` chai wen
2013-10-10 7:15 ` Gleb Natapov
2013-10-10 7:53 ` Gu Zheng
2013-10-10 8:01 ` Gleb Natapov
2013-10-10 8:05 ` Gu Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008073914.GA3574@redhat.com \
--to=gleb@redhat.com \
--cc=chaiw.fnst@cn.fujitsu.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=tangchen@cn.fujitsu.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox