From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754615Ab3JHIQG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Oct 2013 04:16:06 -0400
Received: from mail-ee0-f47.google.com ([74.125.83.47]:36954 "EHLO
	mail-ee0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751717Ab3JHIQD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Oct 2013 04:16:03 -0400
Date: Tue, 8 Oct 2013 10:15:58 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 26/50] tools/perf/build: Split out feature check: 'libbfd'
Message-ID: <20131008081558.GB6706@gmail.com>
References: <1381147003-2574-1-git-send-email-mingo@kernel.org>
 <1381147003-2574-27-git-send-email-mingo@kernel.org>
 <5252CF13.3040200@gmail.com>
 <20131007211858.GB2900@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131007211858.GB2900@krava.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jiri Olsa <jolsa@redhat.com> wrote:

> On Mon, Oct 07, 2013 at 09:11:15AM -0600, David Ahern wrote:
> > On 10/7/13 5:56 AM, Ingo Molnar wrote:
> > >diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> > >index 77a2e6b..4f60ecc 100644
> > >--- a/tools/perf/config/Makefile
> > >+++ b/tools/perf/config/Makefile
> > >@@ -121,6 +121,7 @@ FEATURE_TESTS =				\
> > >  	libperl				\
> > >  	libpython			\
> > >  	libpython-version		\
> > >+	libbfd				\
> > >  	libnuma
> > >
> > >  $(foreach test,$(FEATURE_TESTS),$(call feature_check,$(test),$(test)))
> > 
> > strlcpy missing from FEATURE_TESTS, but really the strlcpy changes
> > should be a separate patch.

Indeed, that's an oversight.

> it gets removed completely in here:
>   tools/perf: Turn strlcpy() into a __weak function
> 
> still I think David's right and there should be
> separate patch for strlcpy check

Ok, I have created a separate patch for that, so that's logically 
consistent.

Thanks,

	Ingo