Re: [PATCHv5 00/11] split page table lock for PMD tables

Ingo Molnar
2013-10-08T10:14:19Z

* Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:

> Ingo Molnar wrote:
> >
> > * Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:
> >
> > > > What must arch maintainers do to enable it? Have you any particular
> > > > suggestions, warnings etc to make their lives easier?
> > >
> > > The last patch is a good illustration what need to be done. It's very
> > > straight forward, I don't see any pitfalls.
> >
> > Might make sense to stick that somewhere into Documentation/mm/, to make
> > arch maintainers feel all warm and fuzzy if they look into enabling this
> > feature on their architecture.
>
> I want to rework code around page->ptl a bit more:
> - allow pgtable_page_ctor() to fail and modify callers to handle it;
> - if sizeof(spinlock_t) > sizeof(long) allocate the spinlock_t
> dynamically.
>
> It will allow to use split lock with DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC.
> And it will make -rt guys happier. ;)
>
> After that I'll document it. Does it work for you?

Sounds nice to me!

Thanks,

Ingo