From: Thierry Reding <thierry.reding@gmail.com>
To: Johannes Thumshirn <johannes.thumshirn@men.de>
Cc: Doug Thompson <dougthompson@xmission.com>,
Borislav Petkov <bp@suse.de>, Baruch Siach <baruch@tkos.co.il>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mpc85xx_edac: Remove unused function
Date: Tue, 8 Oct 2013 11:52:57 +0200 [thread overview]
Message-ID: <20131008095257.GC19633@ulmo.nvidia.com> (raw)
In-Reply-To: <20131008063901.GA32409@jtlinux>
[-- Attachment #1: Type: text/plain, Size: 2004 bytes --]
On Tue, Oct 08, 2013 at 08:39:02AM +0200, Johannes Thumshirn wrote:
> On Mon, Oct 07, 2013 at 05:13:55PM +0200, Thierry Reding wrote:
> > Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code)
> > removed the struct platform_driver that held the last reference to the
> > mpc85xx_pci_err_remove() function. Remove the function since it is
> > effectively dead code.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > drivers/edac/mpc85xx_edac.c | 23 -----------------------
> > 1 file changed, 23 deletions(-)
> >
> > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> > index 3eb32f6..b1e7106 100644
> > --- a/drivers/edac/mpc85xx_edac.c
> > +++ b/drivers/edac/mpc85xx_edac.c
> > @@ -326,29 +326,6 @@ err:
> > return res;
> > }
> > EXPORT_SYMBOL(mpc85xx_pci_err_probe);
> > -
> > -static int mpc85xx_pci_err_remove(struct platform_device *op)
> > -{
> > - struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
> > - struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
> > -
> > - edac_dbg(0, "\n");
> > -
> > - out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
> > - orig_pci_err_cap_dr);
> > -
> > - out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
> > -
> > - edac_pci_del_device(pci->dev);
> > -
> > - if (edac_op_state == EDAC_OPSTATE_INT)
> > - irq_dispose_mapping(pdata->irq);
> > -
> > - edac_pci_free_ctl_info(pci);
> > -
> > - return 0;
> > -}
> > -
> > #endif /* CONFIG_PCI */
> >
> > /**************************** L2 Err device ***************************/
> > --
> > 1.8.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Hi Thierry,
>
> Sorry, but I already have this patch in
> http://lkml.indiana.edu/hypermail/linux/kernel/1309.2/03410.html
No worries.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-10-08 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 15:13 [PATCH] mpc85xx_edac: Remove unused function Thierry Reding
2013-10-07 15:34 ` Borislav Petkov
2013-10-08 6:39 ` Johannes Thumshirn
2013-10-08 9:52 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008095257.GC19633@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=baruch@tkos.co.il \
--cc=bp@suse.de \
--cc=dougthompson@xmission.com \
--cc=johannes.thumshirn@men.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).