* [PATCH] mpc85xx_edac: Remove unused function
@ 2013-10-07 15:13 Thierry Reding
2013-10-07 15:34 ` Borislav Petkov
2013-10-08 6:39 ` Johannes Thumshirn
0 siblings, 2 replies; 4+ messages in thread
From: Thierry Reding @ 2013-10-07 15:13 UTC (permalink / raw)
To: Doug Thompson; +Cc: Borislav Petkov, Baruch Siach, linux-edac, linux-kernel
Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code)
removed the struct platform_driver that held the last reference to the
mpc85xx_pci_err_remove() function. Remove the function since it is
effectively dead code.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/edac/mpc85xx_edac.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index 3eb32f6..b1e7106 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -326,29 +326,6 @@ err:
return res;
}
EXPORT_SYMBOL(mpc85xx_pci_err_probe);
-
-static int mpc85xx_pci_err_remove(struct platform_device *op)
-{
- struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
- struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
-
- edac_dbg(0, "\n");
-
- out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
- orig_pci_err_cap_dr);
-
- out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
-
- edac_pci_del_device(pci->dev);
-
- if (edac_op_state == EDAC_OPSTATE_INT)
- irq_dispose_mapping(pdata->irq);
-
- edac_pci_free_ctl_info(pci);
-
- return 0;
-}
-
#endif /* CONFIG_PCI */
/**************************** L2 Err device ***************************/
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mpc85xx_edac: Remove unused function
2013-10-07 15:13 [PATCH] mpc85xx_edac: Remove unused function Thierry Reding
@ 2013-10-07 15:34 ` Borislav Petkov
2013-10-08 6:39 ` Johannes Thumshirn
1 sibling, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2013-10-07 15:34 UTC (permalink / raw)
To: Thierry Reding
Cc: Doug Thompson, Borislav Petkov, Baruch Siach, linux-edac,
linux-kernel, Johannes Thumshirn
I'm guessing this one is for Johannes. CCed...
On Mon, Oct 07, 2013 at 05:13:55PM +0200, Thierry Reding wrote:
> Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code)
> removed the struct platform_driver that held the last reference to the
> mpc85xx_pci_err_remove() function. Remove the function since it is
> effectively dead code.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/edac/mpc85xx_edac.c | 23 -----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 3eb32f6..b1e7106 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -326,29 +326,6 @@ err:
> return res;
> }
> EXPORT_SYMBOL(mpc85xx_pci_err_probe);
> -
> -static int mpc85xx_pci_err_remove(struct platform_device *op)
> -{
> - struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
> - struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
> -
> - edac_dbg(0, "\n");
> -
> - out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
> - orig_pci_err_cap_dr);
> -
> - out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
> -
> - edac_pci_del_device(pci->dev);
> -
> - if (edac_op_state == EDAC_OPSTATE_INT)
> - irq_dispose_mapping(pdata->irq);
> -
> - edac_pci_free_ctl_info(pci);
> -
> - return 0;
> -}
> -
> #endif /* CONFIG_PCI */
>
> /**************************** L2 Err device ***************************/
> --
> 1.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mpc85xx_edac: Remove unused function
2013-10-07 15:13 [PATCH] mpc85xx_edac: Remove unused function Thierry Reding
2013-10-07 15:34 ` Borislav Petkov
@ 2013-10-08 6:39 ` Johannes Thumshirn
2013-10-08 9:52 ` Thierry Reding
1 sibling, 1 reply; 4+ messages in thread
From: Johannes Thumshirn @ 2013-10-08 6:39 UTC (permalink / raw)
To: Thierry Reding
Cc: Doug Thompson, Borislav Petkov, Baruch Siach, linux-edac,
linux-kernel
On Mon, Oct 07, 2013 at 05:13:55PM +0200, Thierry Reding wrote:
> Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code)
> removed the struct platform_driver that held the last reference to the
> mpc85xx_pci_err_remove() function. Remove the function since it is
> effectively dead code.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/edac/mpc85xx_edac.c | 23 -----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 3eb32f6..b1e7106 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -326,29 +326,6 @@ err:
> return res;
> }
> EXPORT_SYMBOL(mpc85xx_pci_err_probe);
> -
> -static int mpc85xx_pci_err_remove(struct platform_device *op)
> -{
> - struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
> - struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
> -
> - edac_dbg(0, "\n");
> -
> - out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
> - orig_pci_err_cap_dr);
> -
> - out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
> -
> - edac_pci_del_device(pci->dev);
> -
> - if (edac_op_state == EDAC_OPSTATE_INT)
> - irq_dispose_mapping(pdata->irq);
> -
> - edac_pci_free_ctl_info(pci);
> -
> - return 0;
> -}
> -
> #endif /* CONFIG_PCI */
>
> /**************************** L2 Err device ***************************/
> --
> 1.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Thierry,
Sorry, but I already have this patch in
http://lkml.indiana.edu/hypermail/linux/kernel/1309.2/03410.html
But anyways, thanks
Johannes
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mpc85xx_edac: Remove unused function
2013-10-08 6:39 ` Johannes Thumshirn
@ 2013-10-08 9:52 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2013-10-08 9:52 UTC (permalink / raw)
To: Johannes Thumshirn
Cc: Doug Thompson, Borislav Petkov, Baruch Siach, linux-edac,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2004 bytes --]
On Tue, Oct 08, 2013 at 08:39:02AM +0200, Johannes Thumshirn wrote:
> On Mon, Oct 07, 2013 at 05:13:55PM +0200, Thierry Reding wrote:
> > Commit 905e75c (powerpc/fsl-pci: Unify pci/pcie initialization code)
> > removed the struct platform_driver that held the last reference to the
> > mpc85xx_pci_err_remove() function. Remove the function since it is
> > effectively dead code.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > drivers/edac/mpc85xx_edac.c | 23 -----------------------
> > 1 file changed, 23 deletions(-)
> >
> > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> > index 3eb32f6..b1e7106 100644
> > --- a/drivers/edac/mpc85xx_edac.c
> > +++ b/drivers/edac/mpc85xx_edac.c
> > @@ -326,29 +326,6 @@ err:
> > return res;
> > }
> > EXPORT_SYMBOL(mpc85xx_pci_err_probe);
> > -
> > -static int mpc85xx_pci_err_remove(struct platform_device *op)
> > -{
> > - struct edac_pci_ctl_info *pci = dev_get_drvdata(&op->dev);
> > - struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
> > -
> > - edac_dbg(0, "\n");
> > -
> > - out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_CAP_DR,
> > - orig_pci_err_cap_dr);
> > -
> > - out_be32(pdata->pci_vbase + MPC85XX_PCI_ERR_EN, orig_pci_err_en);
> > -
> > - edac_pci_del_device(pci->dev);
> > -
> > - if (edac_op_state == EDAC_OPSTATE_INT)
> > - irq_dispose_mapping(pdata->irq);
> > -
> > - edac_pci_free_ctl_info(pci);
> > -
> > - return 0;
> > -}
> > -
> > #endif /* CONFIG_PCI */
> >
> > /**************************** L2 Err device ***************************/
> > --
> > 1.8.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Hi Thierry,
>
> Sorry, but I already have this patch in
> http://lkml.indiana.edu/hypermail/linux/kernel/1309.2/03410.html
No worries.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-08 9:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-07 15:13 [PATCH] mpc85xx_edac: Remove unused function Thierry Reding
2013-10-07 15:34 ` Borislav Petkov
2013-10-08 6:39 ` Johannes Thumshirn
2013-10-08 9:52 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).