From: Jens Axboe <axboe@kernel.dk>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: "Matias Bjørling" <m@bjorling.me>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH RFC 0/2] Convert from bio-based to blk-mq
Date: Tue, 8 Oct 2013 12:39:49 -0600 [thread overview]
Message-ID: <20131008183949.GB23288@kernel.dk> (raw)
In-Reply-To: <20131008131036.GC7422@linux.intel.com>
On Tue, Oct 08 2013, Matthew Wilcox wrote:
> On Tue, Oct 08, 2013 at 11:34:20AM +0200, Matias Bjørling wrote:
> > The nvme driver implements itself as a bio-based driver. This primarily because
> > of high lock congestion for high-performance nvm devices. To remove the
> > congestion, a multi-queue block layer is being implemented.
>
> Um, no. You'll crater performance by adding another memory allocation
> (of the struct request). multi-queue is not the solution.
That's a rather "jump to conclusions" statement to make. As Matias
mentioned, there are no extra fast path allocations. Once the tagging is
converted as well, I'd be surprised if it performs worse than before.
And that on top of a net reduction in code.
blk-mq might not be perfect as it stands, but it's a helluva lot better
than a bunch of flash based drivers with lots of duplicated code and
mechanisms. We need to move away from that.
--
Jens Axboe
next prev parent reply other threads:[~2013-10-08 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 9:34 [PATCH RFC 0/2] Convert from bio-based to blk-mq Matias Bjørling
2013-10-08 9:34 ` [PATCH RFC 1/2] blk-mq: call exit_hctx on hw queue teardown Matias Bjørling
2013-10-08 9:34 ` [PATCH RFC 2/2] NVMe: rfc blk-mq support Matias Bjørling
2013-10-08 20:59 ` Keith Busch
2013-10-09 7:12 ` Matias Bjørling
2013-10-08 13:10 ` [PATCH RFC 0/2] Convert from bio-based to blk-mq Matthew Wilcox
2013-10-08 13:19 ` Matias Bjørling
2013-10-08 18:39 ` Jens Axboe [this message]
2013-10-09 15:48 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008183949.GB23288@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).