Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

Sukadev Bhattiprolu
2013-10-08T19:31:44Z

Michael Ellerman [michael@ellerman.id.au] wrote:
| bool is_load_store(int ext_opcode)
| {
| upper = ext_opcode >> 5;
| lower = ext_opcode & 0x1f;
|
| /* Short circuit as many misses as we can */
| if (lower < 3 || lower > 23)
| return false;

I see some loads/stores like these which are not covered by
the above check. Is it ok to ignore them ?

lower == 29: ldepx, stdepx, eviddepx, evstddepx

lower == 31: lwepx, lbepx, lfdepx, stfdepx,

Looking through the opcode maps, I also see these for primary
op code 4:

evldd, evlddx, evldwx, evldw, evldh, evldhx.

Should we include those also ?

Sukadev