From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [GIT PULL] tools/perf/build: Speed up the perf build system
Date: Wed, 9 Oct 2013 11:38:30 -0300 [thread overview]
Message-ID: <20131009143830.GA28369@ghostprotocols.net> (raw)
In-Reply-To: <20131009070149.GA32023@gmail.com>
Em Wed, Oct 09, 2013 at 09:01:49AM +0200, Ingo Molnar escreveu:
> Arnaldo,
>
> Please pull the tools/perf/build git tree from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.tools/perf/build
>
> # HEAD: 165108a92fc554d51e73b143b69b77e7c278da78 tools/perf/build: Clean up feature_print_code()
>
> This tree contains the build system speedup series described at:
>
> https://lkml.org/lkml/2013/10/7/199
>
> Reviewed by David Ahern and Jiri Olsa (thanks guys!).
One problem I just noticed, and that is not preventing me from merging
this now, as it has a (obvious) workaround:
If I try using O= I better make sure the directory it points to exists:
[acme@sandy linux]$ ls -la tools/perf/*.o tools/perf/util/*.o
ls: cannot access tools/perf/*.o: No such file or directory
ls: cannot access tools/perf/util/*.o: No such file or directory
[acme@sandy linux]$ mkdir -p /tmp/build/perf/
[acme@sandy linux]$ time make O=/tmp/build/perf -C tools/perf/ install-bin
make: Entering directory `/home/acme/git/linux/tools/perf'
BUILD: Doing 'make -j8' parallel build
Auto-detecting system features:
... backtrace: [ on ]
... dwarf: [ on ]
<SNIP>
make: Leaving directory `/home/acme/git/linux/tools/perf'
real 0m2.751s
user 0m4.270s
sys 0m1.240s
[acme@sandy linux]$ ls -la tools/perf/*.o tools/perf/util/*.o
ls: cannot access tools/perf/*.o: No such file or directory
ls: cannot access tools/perf/util/*.o: No such file or directory
[acme@sandy linux]$ ls -la /tmp/build/perf/perf
-rwxrwxr-x. 1 acme acme 9791281 Oct 9 11:32 /tmp/build/perf/perf
[acme@sandy linux]$
---------------------------------------------------------------------------------
Works as expected, but if I do:
[acme@sandy linux]$ rm -rf /tmp/build
[acme@sandy linux]$ time make O=/tmp/build/perf -C tools/perf/ install-bin
make: Entering directory `/home/acme/git/linux/tools/perf'
BUILD: Doing 'make -j8' parallel build
Auto-detecting system features:
... backtrace: [ on ]
<SNIP>
make: Leaving directory `/home/acme/git/linux/tools/perf'
real 0m2.715s
user 0m4.118s
sys 0m1.204s
[acme@sandy linux]$ ls -la tools/perf/*.o tools/perf/util/*.o | wc -l
94
[acme@sandy linux]$ ls -la /tmp/build
ls: cannot access /tmp/build: No such file or directory
[acme@sandy linux]$
---------------------------------------------------------------------------------
It silently ignores the O= target, as it doesn't exists.
Previous, expected behaviour is for the build process to stop, complaining that the
target directory doesn't exists.
- Arnaldo
next prev parent reply other threads:[~2013-10-09 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 7:01 [GIT PULL] tools/perf/build: Speed up the perf build system Ingo Molnar
2013-10-09 14:38 ` Arnaldo Carvalho de Melo [this message]
2013-10-09 14:51 ` Ingo Molnar
2013-10-09 15:00 ` [PATCH] tools/perf/build: Fix non-existent build directory handling Ingo Molnar
2013-10-15 5:33 ` [tip:perf/core] " tip-bot for Ingo Molnar
2013-10-09 19:16 ` [GIT PULL] tools/perf/build: Speed up the perf build system Arnaldo Carvalho de Melo
2013-10-09 19:38 ` Arnaldo Carvalho de Melo
2013-10-10 5:42 ` [PATCH] tools/perf/build: Fix redirection printouts Ingo Molnar
2013-10-15 5:31 ` [tip:perf/core] perf tools: " tip-bot for Ingo Molnar
2013-10-10 6:10 ` [PATCH] tools/perf/build: Pass through DEBUG parameter Ingo Molnar
2013-10-10 19:26 ` [GIT PULL] tools/perf/build: Speed up the perf build system Arnaldo Carvalho de Melo
2013-10-10 19:50 ` Arnaldo Carvalho de Melo
2013-10-10 20:06 ` Arnaldo Carvalho de Melo
2013-10-10 22:13 ` Jiri Olsa
2013-10-10 22:29 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009143830.GA28369@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox