From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Dhaval Giani <dhaval.giani@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
mingo@kernel.org, laijs@cn.fujitsu.com,
Dipankar <dipankar@in.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
josh@joshtriplett.org, Nivedita Singhvi <niv@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
David Howells <dhowells@redhat.com>,
edumazet@google.com, Darren Hart <darren@dvhart.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
sbw@mit.edu, "David S. Miller" <davem@davemloft.net>,
Thomas Graf <tgraf@suug.ch>, Gao feng <gaofeng@cn.fujitsu.com>,
Stephen Hemminger <shemminger@vyatta.com>,
linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2 tip/core/rcu 05/13] decnet: Apply rcu_access_pointer() to avoid sparse false positive
Date: Wed, 9 Oct 2013 16:54:11 -0700 [thread overview]
Message-ID: <20131009235411.GH5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAPhKKr8kLDNd7CdksHriyMzsqcj0oSf7mAfLceviMjobYGy7oA@mail.gmail.com>
On Wed, Oct 09, 2013 at 06:58:47PM -0400, Dhaval Giani wrote:
> On Wed, Oct 9, 2013 at 5:29 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> >
> > From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> >
> > The sparse checking for rcu_assign_pointer() was recently upgraded
> > to reject non-__kernel address spaces. This also rejects __rcu,
> > which is almost always the right thing to do. However, the use in
> > dn_insert_route() is legitimate: It is assigning a pointer to an element
> > from an RCU-protected list, and all elements of this list are already
> > visible to caller.
> >
> > This commit therefore silences this false positive by laundering the
> > pointer using rcu_access_pointer() as suggested by Josh Triplett.
> >
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
>
> I did not realize that we were allowed to rename people :-)
Copied and pasted directly from the email I received. Perhaps strange,
but true! ;-)
Thanx, Paul
next prev parent reply other threads:[~2013-10-09 23:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 21:29 [PATCH v2 tip/core/rcu 0/13] Sparse-related updates for 3.13 Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 01/13] rcu: Make rcu_assign_pointer's assignment volatile and type-safe Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 02/13] notifiers: Apply rcu_access_pointer() to avoid sparse false positive Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 03/13] bridge: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 04/13] wireless: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 05/13] decnet: " Paul E. McKenney
2013-10-09 22:28 ` Josh Triplett
2013-10-09 22:46 ` Paul E. McKenney
2013-10-09 22:57 ` Josh Triplett
2013-10-09 23:57 ` Paul E. McKenney
2013-10-09 22:58 ` Dhaval Giani
2013-10-09 23:54 ` Paul E. McKenney [this message]
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 06/13] ipv4/ip_socketglue: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 07/13] ipv6/ip6_tunnel: " Paul E. McKenney
2013-10-09 21:42 ` Eric Dumazet
2013-10-09 21:57 ` Paul E. McKenney
2013-10-09 22:10 ` Eric Dumazet
2013-10-09 22:36 ` Paul E. McKenney
2013-10-09 22:51 ` Eric Dumazet
2013-10-09 22:56 ` Josh Triplett
2013-10-09 23:17 ` Eric Dumazet
2013-10-09 23:40 ` Josh Triplett
2013-10-10 0:12 ` Eric Dumazet
2013-10-10 0:28 ` Paul E. McKenney
2013-10-10 2:04 ` Hannes Frederic Sowa
2013-10-10 19:05 ` Paul E. McKenney
2013-10-12 2:25 ` Hannes Frederic Sowa
2013-10-12 7:53 ` Paul E. McKenney
2013-10-12 16:43 ` Hannes Frederic Sowa
2013-10-12 17:37 ` Hannes Frederic Sowa
2013-10-12 19:42 ` Mathieu Desnoyers
2013-10-13 11:14 ` Paul E. McKenney
2013-10-13 20:11 ` Hannes Frederic Sowa
2013-10-11 0:20 ` Josh Triplett
2013-10-11 13:25 ` Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 08/13] ipv6/ip6_gre: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 09/13] ipv6/sit: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 10/13] mac80211: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 11/13] bridge/br_mdb: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 12/13] bonding/bond_main: " Paul E. McKenney
2013-10-09 21:29 ` [PATCH v2 tip/core/rcu 13/13] bonding/bond_alb.c: " Paul E. McKenney
2013-10-09 22:26 ` [PATCH v2 tip/core/rcu 01/13] rcu: Make rcu_assign_pointer's assignment volatile and type-safe Josh Triplett
2013-10-09 22:18 ` [PATCH v2 tip/core/rcu 0/13] Sparse-related updates for 3.13 Josh Triplett
2013-10-09 22:46 ` Paul E. McKenney
2013-10-09 22:23 ` Josh Triplett
2013-10-09 22:30 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009235411.GH5790@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=davem@davemloft.net \
--cc=dhaval.giani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=shemminger@vyatta.com \
--cc=tglx@linutronix.de \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox