public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dong Zhu <bluezhudong@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	John Stultz <john.stultz@linaro.org>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: [PATCH RESEND] timer stats: reset entries when disable the timer usage statistics
Date: Thu, 10 Oct 2013 10:59:47 +0800	[thread overview]
Message-ID: <20131010025947.GD2139@zhudong.nay.redhat.com> (raw)

>From f41628c61d8a9172677ba33a55b61e37ce28f7a6 Mon Sep 17 00:00:00 2001
From: Dong Zhu <bluezhudong@gmail.com> 
Date: Thu, 10 Oct 2013 10:38:13 +0800

When we stop timer statistics collection (via echo 0 >
/proc/timers_stats), the statistics data is still exported as if it were
correct, which can cause applicaitons to misuse the statistics.

This patch resets the statistics when we stop collecting them, to avoid
this problem.

Signed-off-by: Dong Zhu <bluezhudong@gmail.com>
---
 kernel/time/timer_stats.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/time/timer_stats.c b/kernel/time/timer_stats.c
index 0b537f2..43f05e7 100644
--- a/kernel/time/timer_stats.c
+++ b/kernel/time/timer_stats.c
@@ -371,6 +371,7 @@ static ssize_t tstats_write(struct file *file, const char __user *buf,
 	switch (ctl[0]) {
 	case '0':
 		if (timer_stats_active) {
+			reset_entries();
 			timer_stats_active = 0;
 			time_stop = ktime_get();
 			sync_access();
-- 
1.7.11.7

-- 
Best Regards,
Dong Zhu

             reply	other threads:[~2013-10-10  2:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10  2:59 Dong Zhu [this message]
2013-10-10  4:04 ` [PATCH RESEND] timer stats: reset entries when disable the timer usage statistics John Stultz
2013-10-10  4:35 ` Ingo Molnar
2013-10-10  4:48   ` John Stultz
2013-10-10  6:14   ` [PATCH v2] timer stats: add a 'status' line to " Dong Zhu
2013-10-10  6:16     ` Ingo Molnar
2013-10-10  6:55       ` [PATCH v0.3] " Dong Zhu
2013-10-10  7:26         ` Ingo Molnar
2013-10-10  7:56           ` [PATCH v4] " Dong Zhu
2013-10-10 11:25             ` [tip:timers/core] timer stats: Add a 'Collection: active/inactive ' " tip-bot for Dong Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010025947.GD2139@zhudong.nay.redhat.com \
    --to=bluezhudong@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox