Re: [PATCH v0.3] timer stats: add a 'status' line to timer usage statistics

[Ingo Molnar <mingo@kernel.org>]

* Dong Zhu <bluezhudong@gmail.com> wrote:

> > > Agree, I modified this patch and resubmited it again, Could you help
> > > reviewing it again ? Thanks !
> > > 
> > > From 263c40abea8011c82582b2d671ae783b26f44bd5 Mon Sep 17 00:00:00 2001
> > > From: Dong Zhu <bluezhudong@gmail.com> 
> > > Date: Thu, 10 Oct 2013 13:46:08 +0800
> > > 
> > > We can enable|disable timer statistics collection (via echo [1|0] >
> > > /proc/timers_stats), this patch adds a 'status' line to display the
> > > current timer collection status.
> > > 
> > > Signed-off-by: Dong Zhu <bluezhudong@gmail.com>
> > > ---
> > >  kernel/time/timer_stats.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/kernel/time/timer_stats.c b/kernel/time/timer_stats.c
> > > index 0b537f2..bac5e91 100644
> > > --- a/kernel/time/timer_stats.c
> > > +++ b/kernel/time/timer_stats.c
> > > @@ -303,6 +303,10 @@ static int tstats_show(struct seq_file *m, void *v)
> > >  	if (atomic_read(&overflow_count))
> > >  		seq_printf(m, "Overflow: %d entries\n",
> > >  			atomic_read(&overflow_count));
> > > +	if (timer_stats_active)
> > > +		seq_puts(m, "Status: collection active\n");
> > > +	else
> > > +		seq_puts(m, "Status: collection disabled\n");
> > 
> > I suspect we could do something like:
> > 
> > 	seq_printf("Status: collection %s\n", timer_stats_active ? "enabled" : "disabled");
> > 
> > and save a bit of kernel image size?
> > 
> > Also, please bump up the version to v0.3, to give parsers a chance.

I think you forgot about this suggestion of mine.

Thanks,

	Ingo