Re: [PATCH 3/3] spi: attach/detach SPI device to the ACPI power domain

Mika Westerberg
2013-10-10T06:07:32Z

On Wed, Oct 09, 2013 at 06:55:28PM +0100, Mark Brown wrote:
> On Wed, Oct 09, 2013 at 05:04:21PM +0300, Mika Westerberg wrote:
> > If the SPI device is enumerated from ACPI namespace (it has an ACPI handle)
> > it might have ACPI methods that needs to be called in order to transition
> > the device to different power states (such as _PSx).
>
> Acked-by: Mark Brown <broonie@linaro.org>

Thanks!

> > + if (ACPI_HANDLE(&spi->dev))
> > + acpi_dev_pm_attach(&spi->dev, true);
>
> Though I do wonder if it wouldn't be sensible to push the if () here
> inside acpi_dev_pm_attach() and similarly for _detach(). Terribly
> trivial either way.

Actually, the check is already there in acpi_dev_pm_attach()/detach(). The
above code follows what Rafael did for platform bus previously. I think the
idea is to have visual hint that this is only for ACPI enumerated devices.

If preferred, I can drop the if() checks, though.