Re: [PATCH 3/3] spi: attach/detach SPI device to the ACPI power domain

Mark Brown
2013-10-09T17:55:57Z

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On Wed, Oct 09, 2013 at 05:04:21PM +0300, Mika Westerberg wrote:
> If the SPI device is enumerated from ACPI namespace (it has an ACPI handle)
> it might have ACPI methods that needs to be called in order to transition
> the device to different power states (such as _PSx).

Acked-by: Mark Brown <broonie@linaro.org>

> + if (ACPI_HANDLE(&spi->dev))
> + acpi_dev_pm_attach(&spi->dev, true);

Though I do wonder if it wouldn't be sensible to push the if () here
inside acpi_dev_pm_attach() and similarly for _detach(). Terribly
trivial either way.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]