From: Guenter Roeck <linux@roeck-us.net>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
platform-driver-x86@vger.kernel.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: Re: [PATCH v2 09/10] intel_mid: Moved board related code to a new file
Date: Thu, 10 Oct 2013 03:52:35 -0700 [thread overview]
Message-ID: <20131010105235.GA25140@roeck-us.net> (raw)
In-Reply-To: <1381384807-14146-10-git-send-email-david.a.cohen@linux.intel.com>
On Wed, Oct 09, 2013 at 11:00:06PM -0700, David Cohen wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> +# I2C Devices
> +obj-$(subst m,y,$(CONFIG_SENSORS_EMC1403)) += platform_emc1403.o
> +obj-$(subst m,y,$(CONFIG_SENSORS_LIS3LV02D)) += platform_lis331.o
I am a bit confused by the platform data for the above i2c devices.
The driver for EMC1403 does supports neither interrupts nor platform data.
The driver for LIS3LV02D supports both, but the platform data does not
seem to match what is provided here. Am I missing something ?
> +obj-$(subst m,y,$(CONFIG_GPIO_PCA953X)) += platform_max7315.o
> +obj-$(subst m,y,$(CONFIG_SENSORS_MPU3050)) += platform_mpu3050.o
Do you possibly mean CONFIG_INPUT_MPU3050 ?
Guenter
next prev parent reply other threads:[~2013-10-10 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 5:59 [PATCH v2 00/10] rework arch/x86/platform/[mrst => intel-mid] David Cohen
2013-10-10 5:59 ` [PATCH v2 01/10] mrst: Fixed printk/pr_* related issues David Cohen
2013-10-10 5:59 ` [PATCH v2 02/10] mrst: Fixed indentation issues David Cohen
2013-10-10 6:00 ` [PATCH v2 03/10] mrst: Fixed checkpatch warnings David Cohen
2013-10-10 6:00 ` [PATCH v2 04/10] intel_mid: Renamed *mrst* to *intel_mid* David Cohen
2013-10-10 6:00 ` [PATCH v2 05/10] " David Cohen
2013-10-10 6:00 ` [PATCH v2 06/10] intel_mid: Refactored sfi_parse_devs() function David Cohen
2013-10-10 6:00 ` [PATCH v2 07/10] intel_mid: Added custom device_handler support David Cohen
2013-10-10 6:00 ` [PATCH v2 08/10] intel_mid: Added custom handler for ipc devices David Cohen
2013-10-10 6:00 ` [PATCH v2 09/10] intel_mid: Moved board related code to a new file David Cohen
2013-10-10 10:52 ` Guenter Roeck [this message]
2013-10-10 19:27 ` sathyanarayanan.kuppuswamy
2013-10-10 6:00 ` [PATCH v2 10/10] intel_mid: Moved SFI related code to intel_mid_sfi.c David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010105235.GA25140@roeck-us.net \
--to=linux@roeck-us.net \
--cc=david.a.cohen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox