From: Wolfram Sang <wsa@the-dreams.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Ionut Nicu <ioan.nicu.ext@nsn.com>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Alexander Sverdlin <alexander.sverdlin@nsn.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep
Date: Thu, 10 Oct 2013 21:43:54 +0200 [thread overview]
Message-ID: <20131010194354.GC23512@katana> (raw)
In-Reply-To: <52566971.5020700@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Thu, Oct 10, 2013 at 10:46:41AM +0200, Lars-Peter Clausen wrote:
> > + if (gpio_cansleep(gpio))
> > + gpio_set_value_cansleep(gpio, val & (1 << i));
> > + else
> > + gpio_set_value(gpio, val & (1 << i));
>
> The proper way to do this is just always use the _cansleep() version.
> gpio_set_value() only works for chips which do not sleep,
> gpio_set_value_cansleep() works for both those who do sleep and those who do
> not.
To the gpio-list: Has it been considered to have sth. like
gpio_set_value and gpio_set_value_nosleep? I'd think it makes more sense
to have the specific function have the specific name.
Regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-10 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 8:39 [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep Ionut Nicu
2013-10-10 8:46 ` Wolfram Sang
2013-10-10 8:46 ` Lars-Peter Clausen
2013-10-10 8:57 ` Ionut Nicu
2013-10-10 19:43 ` Wolfram Sang [this message]
2013-10-10 19:51 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010194354.GC23512@katana \
--to=wsa@the-dreams.de \
--cc=alexander.sverdlin@nsn.com \
--cc=ioan.nicu.ext@nsn.com \
--cc=lars@metafoo.de \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.korsgaard@barco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox