From: Karel Zak <kzak@redhat.com>
To: Doug Anderson <dianders@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
Matt Fleming <matt.fleming@intel.com>,
Sean Paul <seanpaul@chromium.org>,
Olof Johansson <olof@lixom.net>,
Bill Richardson <wfrichar@chromium.org>,
Josh Triplett <josh@joshtriplett.org>,
Davidlohr Bueso <davidlohr@hp.com>
Subject: Re: [PATCH] partitions/efi: treat size mismatch as a warning, not an error
Date: Fri, 11 Oct 2013 11:51:39 +0200 [thread overview]
Message-ID: <20131011095139.GA24613@x2.net.home> (raw)
In-Reply-To: <1381447702-6240-1-git-send-email-dianders@chromium.org>
On Thu, Oct 10, 2013 at 04:28:22PM -0700, Doug Anderson wrote:
> + *
> + * Consider a bad value here to be a warning to support dd-ing
> + * an image from a smaller disk to a bigger disk.
> */
> if (ret == GPT_MBR_PROTECTIVE) {
> sz = le32_to_cpu(mbr->partition_record[part].size_in_lba);
> if (sz != (uint32_t) total_sectors - 1 && sz != 0xFFFFFFFF)
> - ret = 0;
> + pr_warn("%s: mbr size mismatch (%u != %u)\n", __func__,
> + sz, (uint32_t)((uint32_t) total_sectors - 1));
> }
I did the same change to util-linux v2.24 fdisk, so you can use the fdisk
to update your protective MBR and boot without warnings.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-10-11 9:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 23:26 Regression parsing GPT (EFI) partition tables Josh Triplett
2013-10-10 0:37 ` Davidlohr Bueso
2013-10-10 20:15 ` Doug Anderson
2013-10-10 21:26 ` Davidlohr Bueso
2013-10-10 21:53 ` Bill Richardson
2013-10-10 22:31 ` Davidlohr Bueso
2013-10-10 23:40 ` Doug Anderson
2013-10-10 22:29 ` Doug Anderson
2013-10-10 22:49 ` Davidlohr Bueso
2013-10-10 23:28 ` [PATCH] partitions/efi: treat size mismatch as a warning, not an error Doug Anderson
2013-10-11 0:25 ` Josh Triplett
2013-10-11 0:31 ` Davidlohr Bueso
2013-10-11 15:48 ` Doug Anderson
2013-10-11 9:51 ` Karel Zak [this message]
2013-10-11 15:53 ` Doug Anderson
2013-10-11 15:47 ` [PATCH v2] " Doug Anderson
2013-10-11 16:11 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011095139.GA24613@x2.net.home \
--to=kzak@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=davidlohr@hp.com \
--cc=dianders@chromium.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=olof@lixom.net \
--cc=seanpaul@chromium.org \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox