From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5)
Date: Fri, 11 Oct 2013 14:59:35 +0200 [thread overview]
Message-ID: <20131011125935.GA10634@gmail.com> (raw)
In-Reply-To: <8761t4cizo.fsf@sejong.aot.lge.com>
* Namhyung Kim <namhyung@kernel.org> wrote:
> Hi Jiri,
>
> On Fri, 11 Oct 2013 09:34:48 +0200, Jiri Olsa wrote:
> > On Fri, Oct 11, 2013 at 07:58:29AM +0200, Ingo Molnar wrote:
> >>
> >> * Namhyung Kim <namhyung@kernel.org> wrote:
> >>
> >> > Hello,
> >> >
> >> > This is a new version of callchain improvement patchset. Basically
> >> > it's almost same as v4 but rebased on current acme/perf/core and some
> >> > functions are renamed as Frederic requested.
> >> >
> >> > Now I'm hunting down a bug in 'perf report -s sym' which was found
> >> > during the test, but I think it's not related to this change as it can
> >> > be reproduced in earlier versions too.
> >> >
> >> > I put this series on 'perf/callchain-v5' branch in my tree
> >> >
> >> > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> >> >
> >> > Any comments are welcome, thanks.
> >>
> >> One thing I noticed about call-graph profiling:
> >>
> >> comet:~/tip/tools/perf> ./perf record -g ~/hackbench 10
> >> callchain: Unknown -g option value: /home/mingo/hackbench
> >>
> >> I think a naked -g used to work just fine in the past. Even if such an
> >> error is displayed the output is very unhelpful, it does does a full
> >> perf-record options dump (unnecessary), the bit that is helpful is hidden
> >> amongst many other options:
> >>
> >> -g, --call-graph <mode[,dump_size]>
> >> do call-graph (stack chain/backtrace) recording: [fp] dwarf
> >>
> >> and it took me two reads to see that I should specify 'fp'. The '[fp]'
> >> indicates that fp is the default - but that does not appear to be working.
> >
> > '-g' takes optional parameter, so having it in front of
> > non option string is causing the error, you could use:
> >
> > ./perf record -g -- ~/hackbench 10
>
> Yes, I think this is an unfortunate change to break some user's scripts.
> It'd be great if it detect whether the next argument belongs to the
> option, or if not, pass it to next normally - but it seems to be not so
> simple IMHO.
So, why not keep -g as a shortcut to whatever default call-graph profiling
we want to provide (note, this does not mean it always has to be 'fp'),
and use --call-graph for more specific variants?
a .perfconfig value could even set the default for '-g', so that you don't
have to type '--call-graph dwarf' all the time.
Thanks,
Ingo
next prev parent reply other threads:[~2013-10-11 12:59 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 5:15 [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5) Namhyung Kim
2013-10-11 5:15 ` [PATCH 1/8] perf callchain: Convert children list to rbtree Namhyung Kim
2013-10-23 7:54 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-10-23 11:07 ` Frederic Weisbecker
2013-10-23 12:45 ` Arnaldo Carvalho de Melo
2013-10-11 5:15 ` [PATCH 2/8] perf ui/progress: Add new helper functions for progress bar Namhyung Kim
2013-10-21 18:13 ` Arnaldo Carvalho de Melo
2013-10-22 18:12 ` Namhyung Kim
2013-10-22 13:06 ` Arnaldo Carvalho de Melo
2013-10-11 5:15 ` [PATCH 3/8] perf tools: Show progress on histogram collapsing Namhyung Kim
2013-10-25 10:33 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-10-28 15:03 ` [tip:perf/urgent] perf script python: Fix mem leak due to missing Py_DECREFs on dict entries tip-bot for Joseph Schuchart
2013-10-11 5:15 ` [PATCH 4/8] perf tools: Use an accessor to read thread comm Namhyung Kim
2013-10-11 5:15 ` [PATCH 5/8] perf tools: Add time argument on comm setting Namhyung Kim
2013-10-11 5:15 ` [PATCH 6/8] perf tools: Add new comm infrastructure Namhyung Kim
2013-10-25 10:56 ` Frederic Weisbecker
2013-10-25 13:04 ` Arnaldo Carvalho de Melo
2013-10-25 15:33 ` David Ahern
2013-10-25 18:12 ` Frederic Weisbecker
2013-10-25 18:14 ` Arnaldo Carvalho de Melo
2013-10-25 18:19 ` David Ahern
2013-10-28 5:38 ` Namhyung Kim
2013-10-28 9:09 ` Frederic Weisbecker
2013-10-28 9:15 ` Namhyung Kim
2013-10-28 10:12 ` Frederic Weisbecker
2013-10-28 12:43 ` Arnaldo Carvalho de Melo
2013-10-28 14:29 ` Arnaldo Carvalho de Melo
2013-10-28 16:05 ` Frederic Weisbecker
2013-10-28 17:01 ` Arnaldo Carvalho de Melo
2013-10-28 17:48 ` Arnaldo Carvalho de Melo
2013-10-29 9:20 ` Frederic Weisbecker
2013-10-29 13:06 ` Arnaldo Carvalho de Melo
2013-10-11 5:15 ` [PATCH 7/8] perf tools: Compare hists comm by addresses Namhyung Kim
2013-11-04 20:19 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2013-10-11 5:15 ` [PATCH 8/8] perf tools: Get current comm instead of last one Namhyung Kim
2013-10-11 5:58 ` [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5) Ingo Molnar
2013-10-11 7:34 ` Jiri Olsa
2013-10-11 8:24 ` Namhyung Kim
2013-10-11 12:59 ` Ingo Molnar [this message]
2013-10-11 13:04 ` Peter Zijlstra
2013-10-11 15:11 ` David Ahern
2013-10-11 15:20 ` David Ahern
2013-10-11 21:51 ` Andi Kleen
2013-10-11 22:04 ` David Ahern
2013-10-13 10:25 ` Jiri Olsa
2013-10-13 21:18 ` [RFC] perf record,top: Add callchain option into .perfconfig Jiri Olsa
2013-10-13 21:32 ` Andi Kleen
2013-10-14 7:56 ` [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5) Ingo Molnar
2013-10-12 16:53 ` Ingo Molnar
2013-10-12 19:42 ` David Ahern
2013-10-13 5:23 ` Ingo Molnar
2013-10-25 19:09 ` RFP: Fixing "-ga -ag -g fp -g dwarf" was " Arnaldo Carvalho de Melo
2013-10-25 19:22 ` David Ahern
2013-10-25 19:46 ` Arnaldo Carvalho de Melo
2013-10-26 12:03 ` Ingo Molnar
2013-10-26 12:35 ` Jiri Olsa
2013-10-26 14:25 ` [PATCH 0/4] perf tools: Fix -g option handling Jiri Olsa
2013-10-26 14:25 ` [PATCH 1/4] perf tools: Split -g and --call-graph for record command Jiri Olsa
2013-10-27 15:30 ` David Ahern
2013-10-28 17:46 ` Arnaldo Carvalho de Melo
2013-10-28 18:20 ` David Ahern
2013-10-29 5:13 ` Namhyung Kim
2013-10-28 7:59 ` Namhyung Kim
2013-10-29 10:18 ` Jiri Olsa
2013-10-29 12:42 ` Arnaldo Carvalho de Melo
2013-10-29 8:22 ` [tip:perf/urgent] perf record: Split -g and --call-graph tip-bot for Jiri Olsa
2013-10-26 14:25 ` [PATCH 2/4] perf tools: Split -G and --call-graph for top command Jiri Olsa
2013-10-27 15:34 ` David Ahern
2013-10-28 8:06 ` Namhyung Kim
2013-10-29 8:22 ` [tip:perf/urgent] perf top: Split -G and --call-graph tip-bot for Jiri Olsa
2013-10-26 14:25 ` [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig Jiri Olsa
2013-10-27 15:36 ` David Ahern
2013-10-28 8:10 ` Namhyung Kim
2013-10-29 10:18 ` Jiri Olsa
2013-10-29 12:43 ` Arnaldo Carvalho de Melo
2013-10-29 12:46 ` Ingo Molnar
2013-11-01 15:20 ` Jiri Olsa
2013-10-26 14:25 ` [PATCH 4/4] perf tools: Add readable output for callchain debug Jiri Olsa
2013-10-27 15:39 ` David Ahern
2013-10-26 14:32 ` [PATCH 0/4] perf tools: Fix -g option handling Jiri Olsa
2013-10-27 6:56 ` Ingo Molnar
2013-10-29 10:21 ` Jiri Olsa
2013-10-29 10:25 ` Ingo Molnar
2013-10-13 12:34 ` [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5) Jiri Olsa
2013-10-14 1:06 ` Namhyung Kim
2013-10-14 4:50 ` Namhyung Kim
2013-10-14 8:01 ` Jiri Olsa
2013-10-14 8:41 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011125935.GA10634@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).