From: Felipe Balbi <balbi@ti.com>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<b.zolnierkie@samsung.com>, <m.szyprowski@samsung.com>,
<andrzej.p@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers support
Date: Fri, 11 Oct 2013 08:39:52 -0500 [thread overview]
Message-ID: <20131011133952.GE25706@radagast> (raw)
In-Reply-To: <52579967.6020306@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
Hi,
On Fri, Oct 11, 2013 at 08:23:35AM +0200, Robert Baldyga wrote:
> Hello,
>
> On 10/10/2013 06:04 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Oct 09, 2013 at 08:41:57AM +0200, Robert Baldyga wrote:
> >> @@ -2616,14 +2630,19 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> >> s3c_hsotg_set_ep_maxpacket(hsotg, hs_ep->index, mps);
> >>
> >> /* default, set to non-periodic */
> >> + hs_ep->isochronous = 0;
> >> hs_ep->periodic = 0;
> >> hs_ep->halted = 0;
> >
> > this hunk doesn't apply because of this hs_ep->halted line, which patch
> > does this depend on ?
> >
> it depends on http://www.spinics.net/lists/linux-usb/msg94025.html
I'll fix it up by hand this time, but new features shouldn't (ideally)
directly depend on fixes which you just wrote.
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-10-11 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 6:41 [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers support Robert Baldyga
2013-10-10 16:04 ` Felipe Balbi
2013-10-11 6:23 ` Robert Baldyga
2013-10-11 13:39 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011133952.GE25706@radagast \
--to=balbi@ti.com \
--cc=andrzej.p@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox