public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Fangxiaozhi (Franko)" <fangxiaozhi@huawei.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Heyongquan <heyongquan@huawei.com>,
	Wangyuhua <yuhua.wang@huawei.com>,
	"Yili (Neil)" <neil.yi@huawei.com>
Subject: Re: [PATCH 1/1] support new huawei devices in option.c
Date: Fri, 11 Oct 2013 13:57:56 -0700	[thread overview]
Message-ID: <20131011205756.GA8181@kroah.com> (raw)
In-Reply-To: <910F9D9E13B84F4C8FA771DC9BDE99F35E24BA90@szxema506-mbs.china.huawei.com>

On Fri, Oct 11, 2013 at 03:48:21AM +0000, Fangxiaozhi (Franko) wrote:
> 1. Add new supporting declarations to option.c, to support Huawei new devices with new bInterfaceSubClass value.
> Signed-off-by: fangxiaozhi <huananhu@huawei.com>

In the future, can you use an email client that doesn't turn tabs into
spaces, so I don't have to edit the patch by hand?

Also:

> + { USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0x03, 0x01) },
> + { USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0x03, 0x02) },

<snip>

That's a huge list of ids, is there any way we can just mark all of
these as used by the device in an easier manner?

I'll take this for now, but I have a feeling that this list is just
going to get worse over time, right?

thanks,

greg k-h

  reply	other threads:[~2013-10-11 20:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11  3:48 [PATCH 1/1] support new huawei devices in option.c Fangxiaozhi (Franko)
2013-10-11 20:57 ` gregkh [this message]
2013-10-11 22:11   ` Dan Williams
2013-10-12  4:13   ` Fangxiaozhi (Franko)
  -- strict thread matches above, loose matches on Subject: below --
2013-12-02  9:00 Fangxiaozhi (Franko)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011205756.GA8181@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fangxiaozhi@huawei.com \
    --cc=heyongquan@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.yi@huawei.com \
    --cc=yuhua.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox