From: Greg KH <gregkh@linuxfoundation.org>
To: Matthias Beyer <mail@beyermatthias.de>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] drivers: usb: core: devio.c: Coding style fixes
Date: Fri, 11 Oct 2013 17:06:05 -0700 [thread overview]
Message-ID: <20131012000605.GA26571@kroah.com> (raw)
In-Reply-To: <1381441292-6145-5-git-send-email-mail@beyermatthias.de>
On Thu, Oct 10, 2013 at 11:41:30PM +0200, Matthias Beyer wrote:
> @@ -1838,9 +1838,10 @@ static int proc_ioctl(struct dev_state *ps, struct usbdevfs_ioctl *ctl)
> return -ENODEV;
> }
>
> - if (ps->dev->state != USB_STATE_CONFIGURED)
> + if (ps->dev->state != USB_STATE_CONFIGURED) {
> retval = -EHOSTUNREACH;
> - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno)))
> + }
> + else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) {
> retval = -EINVAL;
> else switch (ctl->ioctl_code) {
I don't think you actually built the code after you made this change :(
drivers/usb/core/devio.c: In function ‘proc_ioctl’:
drivers/usb/core/devio.c:1844:2: error: expected ‘}’ before ‘else’
Please be more careful.
thanks,
greg k-h
next prev parent reply other threads:[~2013-10-12 0:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 21:41 [PATCH 0/6] drivers: usb: core: Adapt source to styleguide Matthias Beyer
2013-10-10 21:41 ` [PATCH 1/6] drivers: usb: core: {file,hub,sysfs,usb}.c: Whitespace fixes Matthias Beyer
2013-10-10 21:41 ` [PATCH 2/6] drivers: usb: core: file.c: moved asterisk to variable name Matthias Beyer
2013-10-10 21:41 ` [PATCH 3/6] drivers: usb: core: hub.c: Comments shouldnt be C99 // comment style Matthias Beyer
2013-10-10 21:41 ` [PATCH 4/6] drivers: usb: core: devio.c: Coding style fixes Matthias Beyer
2013-10-12 0:06 ` Greg KH [this message]
2013-10-12 11:01 ` [PATCH 1/1] " Matthias Beyer
2013-10-12 17:19 ` Sergei Shtylyov
2013-10-14 18:12 ` Greg KH
2013-10-14 19:46 ` [PATCH v2 0/5] " Matthias Beyer
2013-10-14 19:46 ` [PATCH v2 1/5] drivers: usb: core: devio.c: Spaces to tabs for proc_reapurbnonblock() Matthias Beyer
2013-10-14 19:46 ` [PATCH v2 2/5] drivers: usb: core: devio.c: Spaces to tabs for proc_control_compat() Matthias Beyer
2013-10-14 19:46 ` [PATCH v2 3/5] drivers: usb: core: devio.c: Braces around if-elseif-else Matthias Beyer
2013-10-16 20:40 ` Greg KH
2013-10-14 19:46 ` [PATCH v2 4/5] drivers: usb: core: devio.c: Reindented switch-block Matthias Beyer
2013-10-14 19:46 ` [PATCH v2 5/5] drivers: usb: core: devio.c: Put arguments on new line Matthias Beyer
2013-10-16 20:40 ` Greg KH
2013-10-10 21:41 ` [PATCH 5/6] drivers: usb: core: devio.c: Braces around switch Matthias Beyer
2013-10-12 0:08 ` Greg KH
2013-10-12 11:05 ` [PATCH 1/1] drivers: usb: core: devio.c: Braces around switch (updated) Matthias Beyer
2013-10-14 18:12 ` Greg KH
2013-10-10 21:41 ` [PATCH 6/6] drivers: usb: core: devio.c: Else should be on closing braces Matthias Beyer
2013-10-12 0:09 ` [PATCH 0/6] drivers: usb: core: Adapt source to styleguide Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131012000605.GA26571@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@beyermatthias.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox