From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754238Ab3JMPRo (ORCPT ); Sun, 13 Oct 2013 11:17:44 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:35454 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762Ab3JMPRn (ORCPT ); Sun, 13 Oct 2013 11:17:43 -0400 Date: Sun, 13 Oct 2013 16:17:29 +0100 From: Matthew Garrett To: Felipe Contreras Cc: "corentin.chary@gmail.com" , "acpi4asus-user@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: [PATCH v2] platform: x86: asus-wmi: add fan control Message-ID: <20131013151729.GA4028@srcf.ucam.org> References: <1381236524-19633-1-git-send-email-felipe.contreras@gmail.com> <1381421199.4248.2.camel@x230.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 13, 2013 at 04:29:34AM -0500, Felipe Contreras wrote: > I don't see anything in acpi_ex_system_memory_space_handler() that > takes into consideration virtual addresses. The spec doesn't seem to constrain it to physical addresses (it just refers to "Control Methods read and write data to locations in address spaces (for example, System memory and System I/O)", so I'd lean towards changing the behaviour of acpica rather than adding virt_to_phys(). -- Matthew Garrett | mjg59@srcf.ucam.org