From: Felipe Balbi <balbi@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>, Felipe Balbi <balbi@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<b-liu@ti.com>
Subject: Re: USB regression in v3.12-rc4
Date: Mon, 14 Oct 2013 14:05:39 -0500 [thread overview]
Message-ID: <20131014190539.GI3132@radagast> (raw)
In-Reply-To: <20131014153356.GA18373@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]
Hi,
On Mon, Oct 14, 2013 at 08:33:56AM -0700, Greg Kroah-Hartman wrote:
> On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote:
> > Hi,
> >
> > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB
> > (peripheral, g_ether).
> >
> > According to git bisect this is caused by:
> >
> > 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit
> > commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61
> > Author: Bin Liu <b-liu@ti.com>
> > Date: Tue Sep 17 15:33:35 2013 -0500
> >
> > usb: musb: gadget: fix otg active status flag
> >
> > In gadget mode, musb->is_active should be set only when connected to the
> > host. musb_g_reset() already takes care of it.
> >
> > Signed-off-by: Bin Liu <b-liu@ti.com>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> >
> > Reverting that commit from v3.12-rc4 will fix the issue. Based on the
> > commit log this is not fixing any real issue, so I wonder why was it
> > included in -rc4 in the first place?
>
> Hm, Felipe, should I just revert this patch for 3.12-final?
Yeah, let's do that... It's unfortunate that tusb6010 is so messed up
:-(
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-14 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 21:46 USB regression in v3.12-rc4 Aaro Koskinen
2013-10-12 23:07 ` Aaro Koskinen
2013-10-14 15:33 ` Greg Kroah-Hartman
2013-10-14 19:05 ` Felipe Balbi [this message]
2013-10-14 20:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014190539.GI3132@radagast \
--to=balbi@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox