linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@gmail.com>,
	tglx@linutronix.de, mingo@redhat.com, rostedt@goodmis.org,
	oleg@redhat.com, fweisbec@gmail.com, darren@dvhart.com,
	johan.eker@ericsson.com, p.faure@akatech.ch,
	linux-kernel@vger.kernel.org, claudio@evidence.eu.com,
	michael@amarulasolutions.com, fchecconi@gmail.com,
	tommaso.cucinotta@sssup.it, nicola.manica@disi.unitn.it,
	luca.abeni@unitn.it, dhaval.giani@gmail.com, hgu1972@gmail.com,
	paulmck@linux.vnet.ibm.com, raistlin@linux.it,
	insop.song@gmail.com, liming.wang@windriver.com,
	jkacur@redhat.com, harald.gustafsson@ericsson.com,
	vincent.guittot@linaro.org,
	bruce.ashfield@windriver.com--no-chain-reply-to
Subject: Re: [PATCH 12/14] sched: make dl_bw a sub-quota of rt_bw
Date: Tue, 15 Oct 2013 15:11:33 +0200	[thread overview]
Message-ID: <20131015131133.GC2402@gmail.com> (raw)
In-Reply-To: <20131015123527.GI10651@twins.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Oct 15, 2013 at 02:25:22PM +0200, Ingo Molnar wrote:
> >
> > Really, please make it _symmetric_ ...
> > 
> > Single core systems are becoming a historic curiosity, should we 
> > should justify every piece of extra complexity we add for them.
> > 
> > So I'd rather see obvious SMP code where the UP case works fine too, 
> > and _then_ maybe check a separate patch that adds the UP optimization, 
> > with (object size) numbers proving that it's worth it, etc.
> 
> That's a slightly larger task than it appears; the core scheduler code 
> they rely on with smp doesn't exist on up.
> 
> We can do this but we need to do it scheduler wide.

The scheduler has over 800 #ifdefs or similar preprocessor directives:

  comet:~/tip> git grep '^#' kernel/sched/ | grep -v include | wc -l
  855

I'd like to see this simplified a bit, _especially_ before we add new 
complexity ...

Thanks,

	Ingo

  reply	other threads:[~2013-10-15 13:11 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-14 10:43 [PATCH 00/14] sched: SCHED_DEADLINE v8 Juri Lelli
2013-10-14 10:43 ` [PATCH 01/14] sched: add sched_class->task_dead Juri Lelli
2013-10-14 10:43 ` [PATCH 02/14] sched: add extended scheduling interface Juri Lelli
2013-10-14 10:43 ` [PATCH 03/14] sched: SCHED_DEADLINE structures & implementation Juri Lelli
2013-10-14 11:10   ` Peter Zijlstra
2013-10-14 13:05     ` Juri Lelli
2013-10-14 13:51       ` Peter Zijlstra
2013-10-14 11:18   ` Peter Zijlstra
2013-10-14 11:24   ` Peter Zijlstra
2013-10-14 14:36     ` Juri Lelli
2013-10-14 11:33   ` Peter Zijlstra
2013-10-14 16:16     ` Juri Lelli
2013-10-14 16:19       ` Peter Zijlstra
2013-10-14 11:44   ` Peter Zijlstra
2013-10-14 16:58     ` Juri Lelli
2013-10-14 17:34       ` Peter Zijlstra
2013-10-14 20:48         ` Juri Lelli
2013-10-14 11:49   ` Peter Zijlstra
2013-10-14 20:36     ` Juri Lelli
2013-10-14 11:51   ` Peter Zijlstra
2013-10-14 21:26     ` Juri Lelli
2013-10-14 10:43 ` [PATCH 04/14] sched: SCHED_DEADLINE SMP-related data structures & logic Juri Lelli
2013-10-14 12:03   ` Peter Zijlstra
2013-10-15  9:36     ` Juri Lelli
2013-10-15 10:35       ` Peter Zijlstra
2013-10-15 11:36         ` Juri Lelli
2013-10-17 16:49         ` [tip:sched/core] sched/rt: Add missing rmb() tip-bot for Peter Zijlstra
2013-10-14 10:43 ` [PATCH 05/14] sched: SCHED_DEADLINE avg_update accounting Juri Lelli
2013-10-14 10:43 ` [PATCH 06/14] sched: add period support for -deadline tasks Juri Lelli
2013-10-14 12:07   ` Peter Zijlstra
2013-10-15  8:23     ` Juri Lelli
2013-10-15  8:43       ` Peter Zijlstra
2013-10-14 10:43 ` [PATCH 07/14] sched: add schedstats " Juri Lelli
2013-10-14 12:08   ` Peter Zijlstra
2013-10-15  9:06     ` Juri Lelli
2013-10-14 10:43 ` [PATCH 08/14] sched: add latency tracing " Juri Lelli
2013-10-14 10:43 ` [PATCH 09/14] rtmutex: turn the plist into an rb-tree Juri Lelli
2013-10-14 10:43 ` [PATCH 10/14] sched: drafted deadline inheritance logic Juri Lelli
2013-10-14 10:43 ` [PATCH 11/14] sched: add bandwidth management for sched_dl Juri Lelli
2013-10-14 10:43 ` [PATCH 12/14] sched: make dl_bw a sub-quota of rt_bw Juri Lelli
2013-10-14 14:06   ` Ingo Molnar
2013-10-15 10:00     ` Juri Lelli
2013-10-15 10:26       ` Peter Zijlstra
2013-10-15 11:35         ` Juri Lelli
2013-10-15 12:25         ` Ingo Molnar
2013-10-15 12:35           ` Peter Zijlstra
2013-10-15 13:11             ` Ingo Molnar [this message]
2013-10-16  8:59               ` Peter Zijlstra
2013-10-16  9:19                 ` Ingo Molnar
2013-10-14 10:43 ` [PATCH 13/14] sched: speed up -dl pushes with a push-heap Juri Lelli
2013-10-14 10:43 ` [PATCH 14/14] sched: add sched_dl documentation Juri Lelli
2013-10-14 10:53 ` [PATCH 00/14] sched: SCHED_DEADLINE v8 Juri Lelli
2013-10-14 12:24 ` Peter Zijlstra
2013-10-14 12:38   ` Ingo Molnar
2013-10-14 13:22     ` Peter Zijlstra
2013-10-14 13:36       ` Ingo Molnar
2013-10-14 13:50         ` Peter Zijlstra
  -- strict thread matches above, loose matches on Subject: below --
2013-11-07 13:43 [PATCH 00/14] sched: SCHED_DEADLINE v9 Juri Lelli
2013-11-07 13:43 ` [PATCH 12/14] sched: make dl_bw a sub-quota of rt_bw Juri Lelli
2013-02-11 18:50 [PATCH 00/14] sched: SCHED_DEADLINE v7 Juri Lelli
2013-02-11 18:50 ` [PATCH 12/14] sched: make dl_bw a sub-quota of rt_bw Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131015131133.GC2402@gmail.com \
    --to=mingo@kernel.org \
    --cc=bruce.ashfield@windriver.com--no-chain-reply-to \
    --cc=claudio@evidence.eu.com \
    --cc=darren@dvhart.com \
    --cc=dhaval.giani@gmail.com \
    --cc=fchecconi@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=harald.gustafsson@ericsson.com \
    --cc=hgu1972@gmail.com \
    --cc=insop.song@gmail.com \
    --cc=jkacur@redhat.com \
    --cc=johan.eker@ericsson.com \
    --cc=juri.lelli@gmail.com \
    --cc=liming.wang@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@unitn.it \
    --cc=michael@amarulasolutions.com \
    --cc=mingo@redhat.com \
    --cc=nicola.manica@disi.unitn.it \
    --cc=oleg@redhat.com \
    --cc=p.faure@akatech.ch \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=raistlin@linux.it \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tommaso.cucinotta@sssup.it \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).