From: Greg KH <gregkh@linuxfoundation.org>
To: Youquan Song <youquan.song@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Youquan Song <youquan.song@intel.com>,
dan.j.williams@intel.com, andriy.shevchenko@intel.com,
mika.westerberg@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dma: Add interface to calculate data transferred
Date: Tue, 15 Oct 2013 08:30:01 -0700 [thread overview]
Message-ID: <20131015153001.GA19236@kroah.com> (raw)
In-Reply-To: <20131015183142.GA12494@linux-youquan.bj.intel.com>
On Tue, Oct 15, 2013 at 02:31:42PM -0400, Youquan Song wrote:
> On Sun, Oct 13, 2013 at 08:56:33PM +0530, Vinod Koul wrote:
> > On Fri, Oct 11, 2013 at 06:33:43AM -0700, Greg KH wrote:
> > > On Fri, Oct 11, 2013 at 05:42:17PM -0400, Youquan Song wrote:
> > > > Currently, the DMA channel calculates its data transferred only at network
> > > > device driver. When other devices like UART or SPI etc, transfers data by DMA
> > > > mode, but it always shows 0 at /sys/class/dma/dma0chan*/bytes_transferred.
> > >
> > > Is that really a problem? I have never heard anyone complaining about
> > > it. Where are the reports of this?
> > Right, am not still getting the point on what is the problem that this series is
> > trying to fix..
>
> The issue is that when I using UART to transfer data between to COMs
> which using Designware DMA controller channel. But I check the specific
> DMA channel by "cat /sys/class/dma/dma0chan3/bytes_transferred", but it
> should all "0". I have transferred data by UART port, why its DMA
> channel report "0" bytes transferred? So I guess that it is possible
> the DMA device driver issue or the data does not use the Designware DMA channel
> fro transferred. After check the code, I notice only when the DMA
> channel used by network device driver and it will record how much data has been
> tranferred, why other device driver will not calculate it. Since DMA
> channel is used by other device driver, why only network is specific? since it is
> common interface, the current /sys/class/dma/dma0chan*/bytes_transferred has
> much possibility to mislead the user.
If you are worried about the data transferred through a UART, then look
at the accounting variables for that device (in /proc/ ) and use them,
they should be a good enough hint to see that data is flowing, not the
dma data.
And again, I can't take this due to the security implications, we
already went down this path with the TTY bytes, why do you want us to
introduce the same issue again only to have to fix it again?
greg k-h
next prev parent reply other threads:[~2013-10-15 15:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 21:42 DMA: Calculate how many data transferred by DMA Youquan Song
2013-10-11 21:42 ` [PATCH 1/2] dma: Add interface to calculate data transferred Youquan Song
2013-10-11 10:22 ` Shevchenko, Andriy
2013-10-11 13:33 ` Greg KH
2013-10-13 15:26 ` Vinod Koul
2013-10-15 18:31 ` Youquan Song
2013-10-15 15:30 ` Greg KH [this message]
2013-10-15 15:55 ` Dan Williams
2013-10-15 16:17 ` Greg KH
2013-10-16 5:38 ` Vinod Koul
2013-10-16 8:36 ` Shevchenko, Andriy
2013-10-16 7:57 ` Vinod Koul
2013-10-16 9:13 ` Shevchenko, Andriy
2013-10-16 14:12 ` Greg KH
2013-10-16 15:07 ` Vinod Koul
2013-10-16 18:17 ` Dan Williams
2013-10-11 21:42 ` [PATCH 2/2] dma: calculate the data tranferred by 8250 Youquan Song
2013-10-11 13:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015153001.GA19236@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=vinod.koul@intel.com \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox