From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Roel Kluin <roel.kluin@gmail.com>,
Andrew Jones <drjones@redhat.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] jump_label: unlikely(x) > 0
Date: Wed, 16 Oct 2013 08:46:59 +0200 [thread overview]
Message-ID: <20131016064659.GA22509@gmail.com> (raw)
In-Reply-To: <525D7315.8080005@linux.intel.com>
* H. Peter Anvin <hpa@linux.intel.com> wrote:
> On 10/11/2013 01:57 PM, Andrew Morton wrote:
> >
> > I'm sure this was intended instead ;) The patch doesn't seem to make
> > any difference in code generation with my gcc.
> >
>
> Which is odd, because doesn't unlikely() booleanize?
It's supposed to:
include/linux/compiler.h:#define unlikely_notrace(x) __builtin_expect(!!(x), 0)
Thanks,
Ingo
prev parent reply other threads:[~2013-10-16 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 20:50 [PATCH] jump_label: unlikely(x) > 0 Roel Kluin
2013-10-11 20:57 ` Andrew Morton
2013-10-15 16:53 ` H. Peter Anvin
2013-10-16 6:46 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016064659.GA22509@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=drjones@redhat.com \
--cc=hpa@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox