From: Johannes Koch <johannes@ortsraum.de>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-kernel@vger.kernel.org, Christian Volkmann <cv@cv-sv.de>
Subject: Re: [PATCH 1/1] cx23885-dvb: fix ds3000 ts2020 split for TEVII S471
Date: Wed, 16 Oct 2013 09:16:08 +0200 [thread overview]
Message-ID: <20131016070245.GA3296@Loki.fritz.box> (raw)
In-Reply-To: <20130926135157.2a26f245@samsung.com>
Hi Mauro,
On Thu, Sep 26, 2013 at 01:51:57PM -0300, Mauro Carvalho Chehab wrote:
> The difference between your patch and the applied one is:
>
> diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c
> index 971e4ff..8ed7b94 100644
> --- a/drivers/media/pci/cx23885/cx23885-dvb.c
> +++ b/drivers/media/pci/cx23885/cx23885-dvb.c
> @@ -1055,7 +1055,6 @@ static int dvb_register(struct cx23885_tsport *port)
> &tevii_ts2020_config, &i2c_bus->i2c_adap);
> fe0->dvb.frontend->ops.set_voltage = f300_set_voltage;
> }
> -
> break;
> case CX23885_BOARD_DVBWORLD_2005:
> i2c_bus = &dev->i2c_bus[1];
> @@ -1285,6 +1284,7 @@ static int dvb_register(struct cx23885_tsport *port)
> if (fe0->dvb.frontend != NULL) {
> dvb_attach(ts2020_attach, fe0->dvb.frontend,
> &tevii_ts2020_config, &i2c_bus->i2c_adap);
> + fe0->dvb.frontend->ops.set_voltage = f300_set_voltage;
> }
> break;
> case CX23885_BOARD_PROF_8000:
>
>
> So, basically, on our patch, you're also filling ops.set_voltage.
>
> As I don't know the board details, I can't tell if this is required or
> not.
>
> Christian/Johannes,
>
> Could you please double-check it? If this is needed, please send me a new
> patch, rebased on the top of linux-media git tree.
no, setting the voltage via dvb.frontend->ops.set_voltage is not needed for
the TeVii S471. See also the patch that introduced S471 support:
https://linuxtv.org/patch/11189/.
Best regards
Johannes
prev parent reply other threads:[~2013-10-16 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 20:58 [PATCH 1/1] cx23885-dvb: fix ds3000 ts2020 split for TEVII S471 Christian Volkmann
2013-09-26 16:51 ` Mauro Carvalho Chehab
2013-10-16 7:16 ` Johannes Koch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016070245.GA3296@Loki.fritz.box \
--to=johannes@ortsraum.de \
--cc=cv@cv-sv.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox