public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@console-pimps.org>
To: Dave Young <dyoung@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	mjg59@srcf.ucam.org, hpa@zytor.com,
	James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
	linux-efi@vger.kernel.org,
	Maarten Lankhorst <maarten.lankhorst@canonical.com>
Subject: Re: [PATCH] x86 efi: efi reverve boot service fix
Date: Wed, 16 Oct 2013 09:07:11 +0100	[thread overview]
Message-ID: <20131016080711.GC10834@console-pimps.org> (raw)
In-Reply-To: <20131016071122.GB18241@dhcp-16-126.nay.redhat.com>

Also better include Maarten on Cc as the author of the code.

On Wed, 16 Oct, at 03:11:22PM, Dave Young wrote:
> typo, fix hpa's mail address..
> 
> On 10/16/13 at 03:03pm, Dave Young wrote:
> > 
> > Current code check boot service region with kernel text region by: 
> > start+size >= __pa_symbol(_text)
> > The end of the above region should be start + size - 1 instead.
> > 
> > I see this problem in ovmf + Fedora 19 grub boot:
> > text start: 1000000 md start: 800000 md size: 800000
> > 
> > Signed-off-by: Dave Young <dyoung@redhat.com>
> > ---
> >  arch/x86/platform/efi/efi.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2.6.orig/arch/x86/platform/efi/efi.c
> > +++ linux-2.6/arch/x86/platform/efi/efi.c
> > @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo
> >  		 * - Not within any part of the kernel
> >  		 * - Not the bios reserved area
> >  		*/
> > -		if ((start+size >= __pa_symbol(_text)
> > +		if ((start + size - 1 >= __pa_symbol(_text)
> >  				&& start <= __pa_symbol(_end)) ||
> >  			!e820_all_mapped(start, start+size, E820_RAM) ||
> >  			memblock_is_region_reserved(start, size)) {

-- 
Matt Fleming, Intel Open Source Technology Center

  parent reply	other threads:[~2013-10-16  8:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16  7:03 [PATCH] x86 efi: efi reverve boot service fix Dave Young
2013-10-16  7:11 ` Dave Young
2013-10-16  7:29   ` H. Peter Anvin
2013-10-16  8:24     ` Dave Young
2013-10-16  8:07   ` Matt Fleming [this message]
2013-10-16  8:28     ` Dave Young
2013-10-16  8:36     ` Maarten Lankhorst
2013-10-16  8:35 ` [PATCH v2] " Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131016080711.GC10834@console-pimps.org \
    --to=matt@console-pimps.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@canonical.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox