From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760292Ab3JPJI0 (ORCPT ); Wed, 16 Oct 2013 05:08:26 -0400 Received: from mail-ea0-f181.google.com ([209.85.215.181]:34971 "EHLO mail-ea0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759029Ab3JPJIX (ORCPT ); Wed, 16 Oct 2013 05:08:23 -0400 Date: Wed, 16 Oct 2013 10:08:19 +0100 From: Lee Jones To: Linus Walleij Cc: Samuel Ortiz , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] mfd: tc3589x: add device tree bindings Message-ID: <20131016090819.GC19112@lee--X1> References: <1381871475-21543-1-git-send-email-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1381871475-21543-1-git-send-email-linus.walleij@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'll let the DT guys do the deep review. Just a couple of small points from me though. 1. MFD patches have the following syntax: mfd: [-sub]: /* Note the uppercase 'D' */ > This defines the device tree bindings for the Toshiba TC3589x > series of multi-purpose expanders. Only the stuff I can test > is defined: GPIO and keypad. Others may implement more > subdevices further down the road. > > Signed-off-by: Linus Walleij > --- > Documentation/devicetree/bindings/mfd/tc3589x.txt | 61 +++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/tc3589x.txt 2. The binding document is normally attached to the patch which applies the bindings, unless we've stopped doing that now. > + > +Example: > + 3. You left off the example? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog