From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760476Ab3JPJ1t (ORCPT ); Wed, 16 Oct 2013 05:27:49 -0400 Received: from mail-ea0-f169.google.com ([209.85.215.169]:59737 "EHLO mail-ea0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760078Ab3JPJ1r (ORCPT ); Wed, 16 Oct 2013 05:27:47 -0400 Date: Wed, 16 Oct 2013 11:27:44 +0200 From: Ingo Molnar To: Matt Fleming Cc: "H. Peter Anvin" , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Fleming , Thomas Gleixner , Peter Jones Subject: Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support Message-ID: <20131016092744.GC23440@gmail.com> References: <1381423261-30566-1-git-send-email-matt@console-pimps.org> <20131010172844.GA26430@gmail.com> <20131011140039.GF12321@console-pimps.org> <20131012174934.GA18849@gmail.com> <525B06CB.6090602@zytor.com> <20131014075726.GB20435@gmail.com> <20131016091648.GD10834@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131016091648.GD10834@console-pimps.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Matt Fleming wrote: > On Mon, 14 Oct, at 09:57:26AM, Ingo Molnar wrote: > > > > * H. Peter Anvin wrote: > > > > > On 10/12/2013 10:49 AM, Ingo Molnar wrote: > > > > > > > >>>> +static void early_efi_write_char(void *dst, char c, int h) > > > >>>> +{ > > > >>>> + const u8 *src; > > > >>>> + u32 fgcolor = 0xaaaaaa; > > > >>> > > > >>> That's RGB grey, right? Why not 0xffffff for a very visible white? > > > >> > > > >> The VGA earlyprintk code uses the equivalent grey, AFAIK, which is why I > > > >> picked this value. > > > > > > > > The VGA code should be changed to white too I suspect ;-) > > > > > > > > > > For compatibility with the classical text console we use light grey as > > > the default color and a double-stroked font (which was necessary on the > > > CGA display since it didn't have enough bandwidth to handle > > > single-stroked fonts well). The problem with changing that to white is > > > that you end up with a mismatch between the earlyprintk console and the > > > "real" console, *or* we change the behavior of everyone's consoles... > > > > Btw., I have no problem at all with making the early console look separate > > and making it clear when we switch to the 'real' console. > > > > earlyprintk is a debug method, and more information can only be good. > > Have we reached a consensus here? I've no strong opinion either way on > the colour of the text. I'd suggest we go white and see whether anyone complains legitimately ... In any case: Acked-by: Ingo Molnar Thanks, Ingo