public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	David Ahern <dsahern@gmail.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] perf: revert PERF_RECORD_MMAP2 support
Date: Wed, 16 Oct 2013 11:30:17 +0200	[thread overview]
Message-ID: <20131016093017.GD23440@gmail.com> (raw)
In-Reply-To: <CABPqkBS3WOKRb3i6d7E=vru7WKffp+PGzi8HYDfyTtGABYHiNw@mail.gmail.com>


* Stephane Eranian <eranian@google.com> wrote:

> > For example by a simple patch that returns -EINVAL (or -ENOSYS) if the 
> > new flag is used - i.e. behaves like the old kernel in that regard - 
> > but leaves the rest in place. (the 'rest' will hopefully be fixed for 
> > v3.13)
>
> That's what I did in my initial revert patch. But it did not include the 
> perf tool revert.

Could the perf tool part have a minimal revert as well?

> I believe in the end, we will still go with the extended MMAP record and 
> not with the physical address (which adds a PERF_SAMPLE_*). So we can 
> leave the attr->mmap2 bit defined and return -EINVAL for now.

Yeah.

> As for the perf tool, we can remove everything and add that later on 
> because the layout of the MMAP2 record may change.

Yes - but can we keep the actual revert patch minimal? I.e. just prevent 
mmap2 records from being generated, or so.

Thanks,

	Ingo

      reply	other threads:[~2013-10-16  9:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 16:18 [PATCH] perf: revert PERF_RECORD_MMAP2 support Stephane Eranian
2013-10-16  6:15 ` Ingo Molnar
2013-10-16  8:28   ` Stephane Eranian
2013-10-16  9:30     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131016093017.GD23440@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=hughd@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox