From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934346Ab3JPMub (ORCPT ); Wed, 16 Oct 2013 08:50:31 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:42112 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934188Ab3JPMu3 (ORCPT ); Wed, 16 Oct 2013 08:50:29 -0400 Date: Wed, 16 Oct 2013 18:20:18 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ingo Molnar , Anton Arapov , David Smith , "Frank Ch. Eigler" , Martin Cermak , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] uprobes: Introduce __create_xol_area() Message-ID: <20131016125018.GH19729@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20131013191815.GA32466@redhat.com> <20131013191835.GA32487@redhat.com> <20131016124125.GE19729@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20131016124125.GE19729@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13101612-0320-0000-0000-000001615854 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > > /* Slot allocation for XOL */ > > -static int xol_add_vma(struct xol_area *area) > > +static int xol_add_vma(struct mm_struct *mm, struct xol_area *area) > > { > > - struct mm_struct *mm = current->mm; > > int ret = -EALREADY; > > > > down_write(&mm->mmap_sem); > > if (mm->uprobes_state.xol_area) > > goto fail; > > > > - ret = -ENOMEM; > > - /* Try to map as high as possible, this is only a hint. */ > > + /* Try to map as high as possible, this is only a hint. */ > > Nit: This comment seems to be shifted unnecessarily. > This gets corrected in the next patch.. Sorry for the noise. -- Thanks and Regards Srikar Dronamraju