From: Greg KH <gregkh@linuxfoundation.org>
To: Dhanunjaya Naidu Ravada <dhanunjaya.matrix@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Staging: comedi: fix semicolon coding style issue in ni_660x.c
Date: Wed, 16 Oct 2013 12:34:44 -0700 [thread overview]
Message-ID: <20131016193444.GA13378@kroah.com> (raw)
In-Reply-To: <1381951492-20654-1-git-send-email-dhanunjaya.matrix@gmail.com>
On Thu, Oct 17, 2013 at 12:54:52AM +0530, Dhanunjaya Naidu Ravada wrote:
> From: Dhanunjaya <dhanunjaya.matrix@gmail.com>
Again, doesn't match the signed-off-by: or From: line on your email :(
> This is a patch to the ni_660x.c file that fixes up a semicolon warning
> found by the checkpatch.pl tool.
No it isn't, it also does something else in this file.
>
> Signed-off-by: Dhanunjaya Naidu Ravada <dhanunjaya.matrix@gmail.com>
> ---
> drivers/staging/comedi/drivers/ni_660x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c
> index 3607336..95bb432 100644
> --- a/drivers/staging/comedi/drivers/ni_660x.c
> +++ b/drivers/staging/comedi/drivers/ni_660x.c
> @@ -28,7 +28,7 @@
> *
> * Encoders work. PulseGeneration (both single pulse and pulse train)
> * works. Buffered commands work for input but not output.
> - *
> + *
That doesn't look like a semicolon fix.
> * References:
> * DAQ 660x Register-Level Programmer Manual (NI 370505A-01)
> * DAQ 6601/6602 User Manual (NI 322137B-01)
> @@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
> s->type = COMEDI_SUBD_COUNTER;
> s->subdev_flags =
> SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL |
> - SDF_CMD_READ /* | SDF_CMD_WRITE */ ;
> + SDF_CMD_READ; /* | SDF_CMD_WRITE */
Nope, please leave the original code, it's correct.
greg k-h
prev parent reply other threads:[~2013-10-16 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 19:24 [PATCH 1/4] Staging: comedi: fix semicolon coding style issue in ni_660x.c Dhanunjaya Naidu Ravada
2013-10-16 19:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016193444.GA13378@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=dhanunjaya.matrix@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox