* [PATCH] Staging: comedi: fix semicolon coding style issue in ni_660x.c
@ 2013-10-16 12:38 Dhanunjaya
2013-10-16 14:07 ` Ian Abbott
2013-10-16 19:38 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Dhanunjaya @ 2013-10-16 12:38 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, wfp5p; +Cc: devel, linux-kernel, Dhanunjaya
This is a patch to the ni_660x.c file that fixes up a semicolon warning
found by the checkpatch.pl tool
---
drivers/staging/comedi/drivers/ni_660x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c
index 3607336..95bb432 100644
--- a/drivers/staging/comedi/drivers/ni_660x.c
+++ b/drivers/staging/comedi/drivers/ni_660x.c
@@ -28,7 +28,7 @@
*
* Encoders work. PulseGeneration (both single pulse and pulse train)
* works. Buffered commands work for input but not output.
- *
+ *
* References:
* DAQ 660x Register-Level Programmer Manual (NI 370505A-01)
* DAQ 6601/6602 User Manual (NI 322137B-01)
@@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
s->type = COMEDI_SUBD_COUNTER;
s->subdev_flags =
SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL |
- SDF_CMD_READ /* | SDF_CMD_WRITE */ ;
+ SDF_CMD_READ; /* | SDF_CMD_WRITE */
s->n_chan = 3;
s->maxdata = 0xffffffff;
s->insn_read = ni_660x_GPCT_rinsn;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: fix semicolon coding style issue in ni_660x.c
2013-10-16 12:38 [PATCH] Staging: comedi: fix semicolon coding style issue in ni_660x.c Dhanunjaya
@ 2013-10-16 14:07 ` Ian Abbott
2013-10-16 19:38 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2013-10-16 14:07 UTC (permalink / raw)
To: Dhanunjaya, Ian Abbott, hsweeten@visionengravers.com,
gregkh@linuxfoundation.org, wfp5p@virginia.edu
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
On 2013-10-16 13:38, Dhanunjaya wrote:
> This is a patch to the ni_660x.c file that fixes up a semicolon warning
> found by the checkpatch.pl tool
> ---
> drivers/staging/comedi/drivers/ni_660x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c
> index 3607336..95bb432 100644
> --- a/drivers/staging/comedi/drivers/ni_660x.c
> +++ b/drivers/staging/comedi/drivers/ni_660x.c
> @@ -28,7 +28,7 @@
> *
> * Encoders work. PulseGeneration (both single pulse and pulse train)
> * works. Buffered commands work for input but not output.
> - *
> + *
> * References:
> * DAQ 660x Register-Level Programmer Manual (NI 370505A-01)
> * DAQ 6601/6602 User Manual (NI 322137B-01)
> @@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
> s->type = COMEDI_SUBD_COUNTER;
> s->subdev_flags =
> SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL |
> - SDF_CMD_READ /* | SDF_CMD_WRITE */ ;
> + SDF_CMD_READ; /* | SDF_CMD_WRITE */
> s->n_chan = 3;
> s->maxdata = 0xffffffff;
> s->insn_read = ni_660x_GPCT_rinsn;
>
Looks good!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: fix semicolon coding style issue in ni_660x.c
2013-10-16 12:38 [PATCH] Staging: comedi: fix semicolon coding style issue in ni_660x.c Dhanunjaya
2013-10-16 14:07 ` Ian Abbott
@ 2013-10-16 19:38 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2013-10-16 19:38 UTC (permalink / raw)
To: Dhanunjaya; +Cc: abbotti, hsweeten, wfp5p, devel, linux-kernel
On Wed, Oct 16, 2013 at 06:08:14PM +0530, Dhanunjaya wrote:
> This is a patch to the ni_660x.c file that fixes up a semicolon warning
> found by the checkpatch.pl tool
> ---
No signed-off-by: so I can't take this patch, sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-16 19:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-16 12:38 [PATCH] Staging: comedi: fix semicolon coding style issue in ni_660x.c Dhanunjaya
2013-10-16 14:07 ` Ian Abbott
2013-10-16 19:38 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox