From: Greg KH <gregkh@linuxfoundation.org>
To: xiao jin <jin.xiao@intel.com>
Cc: oliver@neukum.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] USB: cdc-acm: put delayed_wb to list
Date: Wed, 16 Oct 2013 13:44:33 -0700 [thread overview]
Message-ID: <20131016204433.GA10535@kroah.com> (raw)
In-Reply-To: <1381798895-2980-1-git-send-email-jin.xiao@intel.com>
On Tue, Oct 15, 2013 at 09:01:35AM +0800, xiao jin wrote:
> If acm_write_start during acm suspend, write acm_wb is backuped
> to delayed_wb. When acm resume, the delayed_wb will be started.
> This mechanism can only record one write during acm suspend. More
> acm write will be abandoned.
>
> This patch is to use list_head to record the write acm_wb during acm
> suspend. It can ensure no acm write abandoned.
>
> Signed-off-by: xiao jin <jin.xiao@intel.com>
You obviously did not test this patch at all, as it breaks the build.
Please get a senior Intel kernel developer to sign-off on your future
patches so this does not happen again.
greg k-h
next prev parent reply other threads:[~2013-10-16 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 1:01 [PATCH v2] cdc-acm: put delayed_wb to list xiao jin
2013-10-16 20:44 ` Greg KH [this message]
2013-10-17 0:56 ` [PATCH v2] USB: " Xiao Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016204433.GA10535@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jin.xiao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox