Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro

Chen Gong
2013-10-17T02:46:44Z

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

On Wed, Oct 16, 2013 at 02:02:21PM -0300, Mauro Carvalho Chehab wrote:
> Date: Wed, 16 Oct 2013 14:02:21 -0300
> From: Mauro Carvalho Chehab <m.chehab@samsung.com>
> To: "Chen, Gong" <gong.chen@linux.intel.com>
> Cc: tony.luck@intel.com, bp@alien8.de, joe@perches.com,
> naveen.n.rao@linux.vnet.ibm.com, arozansk@redhat.com,
> linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas
> Winischhofer <thomas@winischhofer.net>, Jean-Christophe Plagniol-Villard
> <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>
> Subject: Re: [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro
> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; x86_64-redhat-linux-gnu)
>
> Em Wed, 16 Oct 2013 10:56:00 -0400
> "Chen, Gong" <gong.chen@linux.intel.com> escreveu:
>
> > GENMASK is used to create a contiguous bitmask([hi:lo]). It is
> > implemented twice in current kernel. One is in EDAC driver, the other
> > is in SiS/XGI FB driver. Move it to a more generic place for other
> > usage.
> >
> > Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Thomas Winischhofer <thomas@winischhofer.net>
> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Acked-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
>
> Btw, there's another incarnation of it at sb_edac.c (GET_BITFIELD).
> It could make sense to also replace it by the newly bitops.h macro.
>
> Regards,
> Mauro

Aha, I will update it in the next version.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]