Re: [PATCH v2 8/9] ACPI, APEI, CPER: Cleanup CPER memory error output format

Borislav Petkov
2013-10-16T17:24:27Z

On Wed, Oct 16, 2013 at 10:56:05AM -0400, Chen, Gong wrote:
> Keep up only the most important fields for memory error
> reporting. The detail information will be moved to perf/trace
> interface.
>
> Suggested-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
> ---
> drivers/acpi/apei/cper.c | 69 +++++++++++++++++++++++-------------------------
> 1 file changed, 33 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/acpi/apei/cper.c b/drivers/acpi/apei/cper.c
> index b1a8a55..f5bc227 100644
> --- a/drivers/acpi/apei/cper.c
> +++ b/drivers/acpi/apei/cper.c
> @@ -33,6 +33,9 @@
> #include <linux/pci.h>
> #include <linux/aer.h>
>
> +#define INDENT_SP " "
> +#define HW_CE_INFO \
> + "Above error has been corrected by h/w and no further action required"

Leftover?

> + if (severity != CPER_SEV_FATAL)
> + printk("%s%s\n", pfx,
> + "Above error has been corrected by h/w "
> + "and require no further action");

Let's write it out and correct grammar:

"Above error has been corrected by the hardware and requires no further action."

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--