linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Jan Beulich <JBeulich@suse.com>, John Stultz <john.stultz@linaro.org>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: honor ACPI FADT flag indicating absence of a CMOS RTC
Date: Fri, 18 Oct 2013 08:29:08 +0200	[thread overview]
Message-ID: <20131018062908.GD14264@gmail.com> (raw)
In-Reply-To: <525E969E02000078000FB710@nat28.tlf.novell.com>


* Jan Beulich <JBeulich@suse.com> wrote:

> We shouldn't be creating a corresponding platform device in that case.

There's a sad lack of context in the changelog, how was it found, does 
this address any problem/bug observed in practice, etc?

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> ---
>  arch/x86/kernel/rtc.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> --- 3.12-rc5/arch/x86/kernel/rtc.c
> +++ 3.12-rc5-x86-ACPI-no-RTC/arch/x86/kernel/rtc.c
> @@ -192,6 +192,11 @@ static __init int add_rtc_cmos(void)
>  	if (mrst_identify_cpu())
>  		return -ENODEV;
>  
> +#ifdef CONFIG_ACPI
> +	if (acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC)
> +		return -ENODEV;
> +#endif

It might also be prudent to emit a KERN_INFO line telling that we don't 
create the device - so that people who suddenly see unexpected breakage or 
change in behavior have a chance to see what we've done?

Thanks,

	Ingo

  reply	other threads:[~2013-10-18  6:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 11:37 [PATCH] x86: honor ACPI FADT flag indicating absence of a CMOS RTC Jan Beulich
2013-10-18  6:29 ` Ingo Molnar [this message]
2013-10-18  7:37   ` Jan Beulich
2013-10-18 10:59     ` Ingo Molnar
2013-10-21  8:31       ` [PATCH v2] " Jan Beulich
2013-10-26 13:51         ` [tip:timers/core] x86/time: Honor " tip-bot for Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131018062908.GD14264@gmail.com \
    --to=mingo@kernel.org \
    --cc=JBeulich@suse.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).