From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Ashley Lai <adlai@linux.vnet.ibm.com>
Cc: Ashley Lai <ashley@ashleylai.com>,
Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Rajiv Andrade <mail@srajiv.net>,
tpmdd-devel@lists.sourceforge.net, Peter H?we <PeterHuewe@gmx.de>,
Sirrix AG <tpmdd@sirrix.com>
Subject: Re: [tpmdd-devel] TPM patches for 2.13
Date: Sun, 20 Oct 2013 11:00:17 -0600 [thread overview]
Message-ID: <20131020170017.GA32542@obsidianresearch.com> (raw)
In-Reply-To: <1382260018.11008.5.camel@fishsauce>
On Sun, Oct 20, 2013 at 04:06:58AM -0500, Ashley Lai wrote:
> Hi Jason,
> Patch 0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch does not meet the
> Linux kernel's coding standards. Please fix the errors found by
> checkpatch.pl and let me know when it's ready. Thanks.
Please use format-patch -M when you run checkpatch on this one:
$ ^scripts/checkpatch.pl `git format-patch -M 890e46c0abf49b6a9bddeab9de8625b71db648ad^\!`
total: 0 errors, 0 warnings, 8 lines checked
0001-tpm-Rename-tpm.c-to-tpm-interface.c.patch has no obvious style problems and is ready for submission.
All the errors it reports without -M are pre-existing in tpm.c, and a
pure rename patch should not clean up pre-existing checkpatch errors,
IMHO..
My strategy to deal with this is to make things checkpatch clean
as they get moved out of tpm-interface.c, so in the follow up patches
tpm-sysfs.c and tpm-dev.c are both checkpatch clean even though the
original code from tpm.c was not.
Jason
next prev parent reply other threads:[~2013-10-20 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 19:31 TPM patches for 2.13 Jason Gunthorpe
2013-10-17 14:57 ` [tpmdd-devel] " Jason Gunthorpe
2013-10-20 9:06 ` Ashley Lai
2013-10-20 17:00 ` Jason Gunthorpe [this message]
2013-10-20 17:47 ` Aw: " Peter Huewe
2013-10-21 23:50 ` Aw: Re: [tpmdd-devel] TPM patches for 3.12 Peter Huewe
2013-10-22 3:04 ` Jason Gunthorpe
2013-10-22 7:31 ` Aw: " Peter Huewe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131020170017.GA32542@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=PeterHuewe@gmx.de \
--cc=adlai@linux.vnet.ibm.com \
--cc=ashley@ashleylai.com \
--cc=leosilva@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@srajiv.net \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@sirrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox