* TPM patches for 2.13
@ 2013-10-06 19:31 Jason Gunthorpe
2013-10-17 14:57 ` [tpmdd-devel] " Jason Gunthorpe
0 siblings, 1 reply; 8+ messages in thread
From: Jason Gunthorpe @ 2013-10-06 19:31 UTC (permalink / raw)
To: Ashley Lai
Cc: Peter H?we, tpmdd-devel, Leonidas Da Silva Barbosa, linux-kernel,
Rajiv Andrade, Sirrix AG
I've prepared this branch:
https://github.com/jgunthorpe/linux/commits/for-tpm
dd783708a8c6fd713c784be68fcbcb7000c43c49
Jason Gunthorpe (11):
tpm: ibmvtpm: Use %zd formatting for size_t format arguments
tpm atmel: Call request_region with the correct base
tpm: Store devname in the tpm_chip
tpm: Use container_of to locate the tpm_chip in tpm_open
tpm: Remove redundant dev_set_drvdata
tpm: st33: Remove chip->data_buffer access from this driver
tpm: Remove tpm_show_caps_1_2
tpm: Rename tpm.c to tpm-interface.c
tpm: Merge the tpm-bios module with tpm.o
tpm: Add support for the Nuvoton NPCT501 I2C TPM
tpm: Add support for Atmel I2C TPMs
Which contains the first half of the clean-up patches and my two
drivers. The cleanups are well ack'd now, and I've done quite a bit of
testing with the two drivers, so I'd like to see agreement that this
batch can move forward as a series, and the other patches can sit
ontop of this series.
I will post the two new patches to the list, the others are not really
changed from prior postings except the commit comments are revised to
reflect acks/etc. Please advise if people would like to see this whole
series posted again.
I've prepared a 2nd branch:
https://github.com/jgunthorpe/linux/commits/tpm-devel
bba72a2e956230af28a7a448f25b4b1076559b40
Jason Gunthorpe:
TPM: STMicroelectronics st33 driver SPI
tpm: Pull everything related to /dev/tpmX into tpm-dev.c
tpm: Pull everything related to sysfs into tpm-sysfs.c
tpm: Create a tpm_class_ops structure and use it in the drivers
tpm: Use the ops structure instead of a copy in tpm_vendor_specific
tpm: Make tpm-dev allocate a per-file structure
Which contains the clean up patches that have not yet had any Acks,
rebased ontop of for-tpm
For reference, here is a top level diff of all source changes relative
to my last posting:
diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
index 2c876a9..2c23374 100644
--- a/drivers/char/tpm/Makefile
+++ b/drivers/char/tpm/Makefile
@@ -1,14 +1,15 @@
#
# Makefile for the kernel tpm device drivers.
#
-obj-$(CONFIG_TCG_TPM) += tpm.o tpm-dev.o tpm-sysfs.o
+obj-$(CONFIG_TCG_TPM) += tpm.o
+tpm-y := tpm-interface.o tpm-dev.o tpm-sysfs.o
+tpm-$(CONFIG_ACPI) += tpm_ppi.o
+
ifdef CONFIG_ACPI
- obj-$(CONFIG_TCG_TPM) += tpm_bios.o
- tpm_bios-objs += tpm_eventlog.o tpm_acpi.o tpm_ppi.o
+ tpm-y += tpm_eventlog.o tpm_acpi.o
else
ifdef CONFIG_TCG_IBMVTPM
- obj-$(CONFIG_TCG_TPM) += tpm_bios.o
- tpm_bios-objs += tpm_eventlog.o tpm_of.o
+ tpm-y += tpm_eventlog.o tpm_of.o
endif
endif
obj-$(CONFIG_TCG_TIS) += tpm_tis.o
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm-interface.c
similarity index 100%
rename from drivers/char/tpm/tpm.c
rename to drivers/char/tpm/tpm-interface.c
diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers/char/tpm/tpm_eventlog.c
index 84ddc55..59f7cb2 100644
--- a/drivers/char/tpm/tpm_eventlog.c
+++ b/drivers/char/tpm/tpm_eventlog.c
@@ -406,7 +406,6 @@ out_tpm:
out:
return NULL;
}
-EXPORT_SYMBOL_GPL(tpm_bios_log_setup);
void tpm_bios_log_teardown(struct dentry **lst)
{
@@ -415,5 +414,3 @@ void tpm_bios_log_teardown(struct dentry **lst)
for (i = 0; i < 3; i++)
securityfs_remove(lst[i]);
}
-EXPORT_SYMBOL_GPL(tpm_bios_log_teardown);
-MODULE_LICENSE("GPL");
diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
index ecdd32a..7576abc 100644
--- a/drivers/char/tpm/tpm_i2c_atmel.c
+++ b/drivers/char/tpm/tpm_i2c_atmel.c
@@ -74,7 +74,7 @@ static int i2c_atmel_recv(struct tpm_chip *chip, u8 *buf, size_t count)
struct i2c_client *client = to_i2c_client(chip->dev);
struct tpm_output_header *hdr =
(struct tpm_output_header *)priv->buffer;
- unsigned int expected_len;
+ u32 expected_len;
int rc;
if (priv->len == 0)
@@ -89,7 +89,7 @@ static int i2c_atmel_recv(struct tpm_chip *chip, u8 *buf, size_t count)
if (priv->len >= expected_len) {
dev_dbg(chip->dev,
- "%s early(buf=%*ph count=%0zx) -> ret=%zd\n", __func__,
+ "%s early(buf=%*ph count=%0zx) -> ret=%d\n", __func__,
(int)min_t(size_t, 64, expected_len), buf, count,
expected_len);
memcpy(buf, priv->buffer, expected_len);
@@ -98,7 +98,7 @@ static int i2c_atmel_recv(struct tpm_chip *chip, u8 *buf, size_t count)
rc = i2c_master_recv(client, buf, expected_len);
dev_dbg(chip->dev,
- "%s reread(buf=%*ph count=%0zx) -> ret=%zd\n", __func__,
+ "%s reread(buf=%*ph count=%0zx) -> ret=%d\n", __func__,
(int)min_t(size_t, 64, expected_len), buf, count,
expected_len);
return rc;
diff --git a/drivers/char/tpm/tpm_ppi.c b/drivers/char/tpm/tpm_ppi.c
index 2168d15..8e562dc 100644
--- a/drivers/char/tpm/tpm_ppi.c
+++ b/drivers/char/tpm/tpm_ppi.c
@@ -452,12 +452,8 @@ int tpm_add_ppi(struct kobject *parent)
{
return sysfs_create_group(parent, &ppi_attr_grp);
}
-EXPORT_SYMBOL_GPL(tpm_add_ppi);
void tpm_remove_ppi(struct kobject *parent)
{
sysfs_remove_group(parent, &ppi_attr_grp);
}
-EXPORT_SYMBOL_GPL(tpm_remove_ppi);
-
-MODULE_LICENSE("GPL");
diff --git a/drivers/char/tpm/tpm_spi_stm_st33.c b/drivers/char/tpm/tpm_spi_stm_st33.c
index 81c61f6..3060d57 100644
--- a/drivers/char/tpm/tpm_spi_stm_st33.c
+++ b/drivers/char/tpm/tpm_spi_stm_st33.c
@@ -743,7 +743,6 @@ tpm_st33_spi_probe(struct spi_device *dev)
tpm_get_timeouts(chip);
- /* attach chip datas to client */
platform_data->bchipf = false;
pr_info("TPM SPI Initialized\n");
diff --git a/include/linux/tpm.h b/include/linux/tpm.h
index a14bf63..fff1d09 100644
--- a/include/linux/tpm.h
+++ b/include/linux/tpm.h
@@ -41,9 +41,6 @@ struct tpm_class_ops {
u8 (*status) (struct tpm_chip *chip);
};
-struct tpm_chip *tpmm_alloc_dev(struct device *dev,
- const struct tpm_class_ops *ops);
-
#if defined(CONFIG_TCG_TPM) || defined(CONFIG_TCG_TPM_MODULE)
extern int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf);
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [tpmdd-devel] TPM patches for 2.13
2013-10-06 19:31 TPM patches for 2.13 Jason Gunthorpe
@ 2013-10-17 14:57 ` Jason Gunthorpe
2013-10-20 9:06 ` Ashley Lai
0 siblings, 1 reply; 8+ messages in thread
From: Jason Gunthorpe @ 2013-10-17 14:57 UTC (permalink / raw)
To: Ashley Lai
Cc: Leonidas Da Silva Barbosa, linux-kernel, Rajiv Andrade,
tpmdd-devel, Peter H?we, Sirrix AG
On Sun, Oct 06, 2013 at 01:31:20PM -0600, Jason Gunthorpe wrote:
> I've prepared this branch:
>
> https://github.com/jgunthorpe/linux/commits/for-tpm
> dd783708a8c6fd713c784be68fcbcb7000c43c49
>
> Jason Gunthorpe (11):
> tpm: ibmvtpm: Use %zd formatting for size_t format arguments
> tpm atmel: Call request_region with the correct base
> tpm: Store devname in the tpm_chip
> tpm: Use container_of to locate the tpm_chip in tpm_open
> tpm: Remove redundant dev_set_drvdata
> tpm: st33: Remove chip->data_buffer access from this driver
> tpm: Remove tpm_show_caps_1_2
> tpm: Rename tpm.c to tpm-interface.c
> tpm: Merge the tpm-bios module with tpm.o
> tpm: Add support for the Nuvoton NPCT501 I2C TPM
> tpm: Add support for Atmel I2C TPMs
>
> Which contains the first half of the clean-up patches and my two
> drivers. The cleanups are well ack'd now, and I've done quite a bit of
> testing with the two drivers, so I'd like to see agreement that this
> batch can move forward as a series, and the other patches can sit
> ontop of this series.
Folks, the 3.13 merge window is fast approaching, any chance of
advancing this work?
Jason
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [tpmdd-devel] TPM patches for 2.13
2013-10-17 14:57 ` [tpmdd-devel] " Jason Gunthorpe
@ 2013-10-20 9:06 ` Ashley Lai
2013-10-20 17:00 ` Jason Gunthorpe
0 siblings, 1 reply; 8+ messages in thread
From: Ashley Lai @ 2013-10-20 9:06 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Ashley Lai, Leonidas Da Silva Barbosa, linux-kernel,
Rajiv Andrade, tpmdd-devel, Peter H?we, Sirrix AG
On Thu, 2013-10-17 at 08:57 -0600, Jason Gunthorpe wrote:
> On Sun, Oct 06, 2013 at 01:31:20PM -0600, Jason Gunthorpe wrote:
> > I've prepared this branch:
> >
> > https://github.com/jgunthorpe/linux/commits/for-tpm
> > dd783708a8c6fd713c784be68fcbcb7000c43c49
> >
> > Jason Gunthorpe (11):
> > tpm: ibmvtpm: Use %zd formatting for size_t format arguments
> > tpm atmel: Call request_region with the correct base
> > tpm: Store devname in the tpm_chip
> > tpm: Use container_of to locate the tpm_chip in tpm_open
> > tpm: Remove redundant dev_set_drvdata
> > tpm: st33: Remove chip->data_buffer access from this driver
> > tpm: Remove tpm_show_caps_1_2
> > tpm: Rename tpm.c to tpm-interface.c
> > tpm: Merge the tpm-bios module with tpm.o
> > tpm: Add support for the Nuvoton NPCT501 I2C TPM
> > tpm: Add support for Atmel I2C TPMs
> >
> > Which contains the first half of the clean-up patches and my two
> > drivers. The cleanups are well ack'd now, and I've done quite a bit of
> > testing with the two drivers, so I'd like to see agreement that this
> > batch can move forward as a series, and the other patches can sit
> > ontop of this series.
>
> Folks, the 3.13 merge window is fast approaching, any chance of
> advancing this work?
>
> Jason
Hi Jason,
Patch 0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch does not meet the
Linux kernel's coding standards. Please fix the errors found by
checkpatch.pl and let me know when it's ready. Thanks.
ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:ERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask,
boolERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:ERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
orERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.ERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $ERROR:
trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:ERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:ERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:ERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:ERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:ERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possibleERROR: trailing
whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#54: FILE: drivers/char/tpm/tpm-interface.c:13:
+ * Specifications at www.trustedcomputinggroup.org^I $
ERROR: trailing whitespace
#60: FILE: drivers/char/tpm/tpm-interface.c:19:
+ * $
WARNING: unnecessary whitespace before a quoted newline
#415: FILE: drivers/char/tpm/tpm-interface.c:374:
+ "invalid count value %x %zx \n", count, bufsiz);
ERROR: do not use assignment in if condition
#421: FILE: drivers/char/tpm/tpm-interface.c:380:
+ if ((rc = chip->vendor.send(chip, (u8 *) buf, count)) < 0) {
ERROR: space required after that ',' (ctx:VxV)
#488: FILE: drivers/char/tpm/tpm-interface.c:447:
+ len = tpm_transmit(chip,(u8 *) cmd, len);
^
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#702: FILE: drivers/char/tpm/tpm-interface.c:661:
+ssize_t tpm_show_enabled(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#718: FILE: drivers/char/tpm/tpm-interface.c:677:
+ssize_t tpm_show_active(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#734: FILE: drivers/char/tpm/tpm-interface.c:693:
+ssize_t tpm_show_owned(struct device * dev, struct device_attribute *
attr,
ERROR: "foo * bar" should be "foo *bar"
#750: FILE: drivers/char/tpm/tpm-interface.c:709:
+ssize_t tpm_show_temp_deactivated(struct device * dev,
ERROR: "foo * bar" should be "foo *bar"
#751: FILE: drivers/char/tpm/tpm-interface.c:710:
+ struct device_attribute * attr, char *buf)
WARNING: please, no space before tabs
#813: FILE: drivers/char/tpm/tpm-interface.c:772:
+ * @chip_num: ^Itpm idx # or ANY$
WARNING: please, no space before tabs
#815: FILE: drivers/char/tpm/tpm-interface.c:774:
+ * @res_buf: ^ITPM_PCR value$
WARNING: please, no space before tabs
#816: FILE: drivers/char/tpm/tpm-interface.c:775:
+ * ^I^Isize of res_buf is 20 bytes (or NULL if you don't care)$
WARNING: please, no space before tabs
#838: FILE: drivers/char/tpm/tpm-interface.c:797:
+ * @chip_num: ^Itpm idx # or AN&$
WARNING: please, no space before tabs
#840: FILE: drivers/char/tpm/tpm-interface.c:799:
+ * @hash: ^Ihash value used to extend pcr value$
ERROR: code indent should use tabs where possible
#892: FILE: drivers/char/tpm/tpm-interface.c:851:
+^I TPM_ORD_CONTINUE_SELFTEST);$
ERROR: trailing whitespace
#1009: FILE: drivers/char/tpm/tpm-interface.c:968:
+^I/* $
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
ERROR: trailing whitespace
#1014: FILE: drivers/char/tpm/tpm-interface.c:973:
+^I parameters (RSA 12->bytes: keybit, #primes, expbit) $
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
WARNING: line over 80 characters
#1136: FILE: drivers/char/tpm/tpm-interface.c:1095:
+static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask, bool
check_cancel,
ERROR: trailing whitespace
#1507: FILE: drivers/char/tpm/tpm-interface.c:1466:
+ * Called from tpm_<specific>.c probe function only for devices $
total: 16 errors, 7 warnings, 1562 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
scripts/cleanfile
./0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch has style problems,
please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--Ashley Lai
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [tpmdd-devel] TPM patches for 2.13
2013-10-20 9:06 ` Ashley Lai
@ 2013-10-20 17:00 ` Jason Gunthorpe
2013-10-20 17:47 ` Aw: " Peter Huewe
2013-10-21 23:50 ` Aw: Re: [tpmdd-devel] TPM patches for 3.12 Peter Huewe
0 siblings, 2 replies; 8+ messages in thread
From: Jason Gunthorpe @ 2013-10-20 17:00 UTC (permalink / raw)
To: Ashley Lai
Cc: Ashley Lai, Leonidas Da Silva Barbosa, linux-kernel,
Rajiv Andrade, tpmdd-devel, Peter H?we, Sirrix AG
On Sun, Oct 20, 2013 at 04:06:58AM -0500, Ashley Lai wrote:
> Hi Jason,
> Patch 0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch does not meet the
> Linux kernel's coding standards. Please fix the errors found by
> checkpatch.pl and let me know when it's ready. Thanks.
Please use format-patch -M when you run checkpatch on this one:
$ ^scripts/checkpatch.pl `git format-patch -M 890e46c0abf49b6a9bddeab9de8625b71db648ad^\!`
total: 0 errors, 0 warnings, 8 lines checked
0001-tpm-Rename-tpm.c-to-tpm-interface.c.patch has no obvious style problems and is ready for submission.
All the errors it reports without -M are pre-existing in tpm.c, and a
pure rename patch should not clean up pre-existing checkpatch errors,
IMHO..
My strategy to deal with this is to make things checkpatch clean
as they get moved out of tpm-interface.c, so in the follow up patches
tpm-sysfs.c and tpm-dev.c are both checkpatch clean even though the
original code from tpm.c was not.
Jason
^ permalink raw reply [flat|nested] 8+ messages in thread
* Aw: Re: [tpmdd-devel] TPM patches for 2.13
2013-10-20 17:00 ` Jason Gunthorpe
@ 2013-10-20 17:47 ` Peter Huewe
2013-10-21 23:50 ` Aw: Re: [tpmdd-devel] TPM patches for 3.12 Peter Huewe
1 sibling, 0 replies; 8+ messages in thread
From: Peter Huewe @ 2013-10-20 17:47 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Ashley Lai, Leonidas Da Silva Barbosa, linux-kernel,
Rajiv Andrade, tpmdd-devel, Sirrix AG
Hi Jason, Ashley,
I think it's okay to leave the checkpatch complaints as they are as they aren't newly introduced.
I'm currently in the process of digging through the patches again and getting the pull request ready.
Maybe I'll fix them while at it.
Thanks,
Peter
> Hi Jason,
> Patch 0008-tpm-Rename-tpm.c-to-tpm-interface.c.patch does not meet the
> Linux kernel's coding standards. Please fix the errors found by
> checkpatch.pl and let me know when it's ready. Thanks.
Please use format-patch -M when you run checkpatch on this one:
$ ^scripts/checkpatch.pl `git format-patch -M 890e46c0abf49b6a9bddeab9de8625b71db648ad^\!`
total: 0 errors, 0 warnings, 8 lines checked
0001-tpm-Rename-tpm.c-to-tpm-interface.c.patch has no obvious style problems and is ready for submission.
All the errors it reports without -M are pre-existing in tpm.c, and a
pure rename patch should not clean up pre-existing checkpatch errors,
IMHO..
My strategy to deal with this is to make things checkpatch clean
as they get moved out of tpm-interface.c, so in the follow up patches
tpm-sysfs.c and tpm-dev.c are both checkpatch clean even though the
original code from tpm.c was not.
Jason
^ permalink raw reply [flat|nested] 8+ messages in thread
* Aw: Re: [tpmdd-devel] TPM patches for 3.12
2013-10-20 17:00 ` Jason Gunthorpe
2013-10-20 17:47 ` Aw: " Peter Huewe
@ 2013-10-21 23:50 ` Peter Huewe
2013-10-22 3:04 ` Jason Gunthorpe
1 sibling, 1 reply; 8+ messages in thread
From: Peter Huewe @ 2013-10-21 23:50 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Ashley Lai, Ashley Lai, Leonidas Da Silva Barbosa, linux-kernel,
Rajiv Andrade, tpmdd-devel, Sirrix AG
Hi Jason, Ashley,
I just pushed the changes to my github tree
https://github.com/PeterHuewe/linux-tpmdd/commits/for-james
along with some additional changes:
- before the rename I made tpm.c checkpatch clean ;)
- I did some cleanup on the indention / white spaces of both Kconfig and bindings for both new drivers
- corrected the module name for the nuvoton i2c module
I detected similar problems with other entries in the kconfig so I
- did also correct the module name for the infineon i2c module (d'oh, my fault ;)
- and also corrected it for the stm i2c module
- cleaned the indention on the st i2c module
I'm currently compile testing it again, I definitely need a newer/faster (small/portable) laptop
(donations welcome ;) - e.g. a 11" ultrabook ;)
Jason, can you please review and test my changes -
I'd probably send the pull request out tomorrow then.
(giving me also the chance to think again whether I should add myself to MAINTAINERS or not ;)
Thanks,
Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re: [tpmdd-devel] TPM patches for 3.12
2013-10-21 23:50 ` Aw: Re: [tpmdd-devel] TPM patches for 3.12 Peter Huewe
@ 2013-10-22 3:04 ` Jason Gunthorpe
2013-10-22 7:31 ` Aw: " Peter Huewe
0 siblings, 1 reply; 8+ messages in thread
From: Jason Gunthorpe @ 2013-10-22 3:04 UTC (permalink / raw)
To: Peter Huewe
Cc: Ashley Lai, Ashley Lai, Leonidas Da Silva Barbosa, linux-kernel,
Rajiv Andrade, tpmdd-devel, Sirrix AG
On Tue, Oct 22, 2013 at 01:50:39AM +0200, Peter Huewe wrote:
> Jason, can you please review and test my changes -
> I'd probably send the pull request out tomorrow then.
> (giving me also the chance to think again whether I should add myself to MAINTAINERS or not ;)
Looks Ok, there are no major diffs against what I had.
Do you need to add your sign off lines on these patches?
tpm: Rename tpm.c to tpm-interface.c
tpm: Merge the tpm-bios module with tpm.o
Thanks,
Jason
^ permalink raw reply [flat|nested] 8+ messages in thread
* Aw: Re: Re: [tpmdd-devel] TPM patches for 3.12
2013-10-22 3:04 ` Jason Gunthorpe
@ 2013-10-22 7:31 ` Peter Huewe
0 siblings, 0 replies; 8+ messages in thread
From: Peter Huewe @ 2013-10-22 7:31 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Ashley Lai, Ashley Lai, Leonidas Da Silva Barbosa, linux-kernel,
Rajiv Andrade, tpmdd-devel, Sirrix AG
> Do you need to add your sign off lines on these patches?
Added to all patches.
Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-10-22 7:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-06 19:31 TPM patches for 2.13 Jason Gunthorpe
2013-10-17 14:57 ` [tpmdd-devel] " Jason Gunthorpe
2013-10-20 9:06 ` Ashley Lai
2013-10-20 17:00 ` Jason Gunthorpe
2013-10-20 17:47 ` Aw: " Peter Huewe
2013-10-21 23:50 ` Aw: Re: [tpmdd-devel] TPM patches for 3.12 Peter Huewe
2013-10-22 3:04 ` Jason Gunthorpe
2013-10-22 7:31 ` Aw: " Peter Huewe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox