From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bin Gao <bin.gao@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] drivers/misc: add rawio framework driver
Date: Tue, 22 Oct 2013 06:45:38 +0100 [thread overview]
Message-ID: <20131022054538.GB14163@kroah.com> (raw)
In-Reply-To: <5265C0C8.10609@linux.intel.com>
On Mon, Oct 21, 2013 at 05:03:20PM -0700, Bin Gao wrote:
> Rawio provides a framework to read/write registers from a bus, including
> pci, i2c, I/O device(memory mapped), etc. based on debug fs.
> Rawio bus drivers implement the read/write operation on a specific bus
> on top of the rawio framework driver.
> They are designed to help device driver and kernel debugging on
> embedded systems.
Oh, one more technical thing, you totally fail to document the
user/kernel api you have just created. You are parsing userspace data
in ways that I really don't understand at all...
greg k-h
next prev parent reply other threads:[~2013-10-22 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 0:03 [PATCH 1/4] drivers/misc: add rawio framework driver Bin Gao
2013-10-22 5:45 ` Greg Kroah-Hartman [this message]
2013-10-22 18:32 ` Bin Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022054538.GB14163@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bin.gao@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox